New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added parameters to Tag::renderTitle() #13706

Merged
merged 4 commits into from Dec 27, 2018

Conversation

Projects
3 participants
@ekmst
Copy link
Contributor

ekmst commented Dec 26, 2018

Hello!

  • Type: new feature
  • Link to issue:

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines?
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.

Small description of change: Changed the Phalcon\Tag::renderTitle() parameters such as Phalcon\Tag::getTitle()

Thanks

@niden

This comment has been minimized.

Copy link
Member

niden commented Dec 26, 2018

@ekmst Would you be so kind as to include in this PR the same change for the Html\Tag component?

@niden

This comment has been minimized.

Copy link
Member

niden commented Dec 26, 2018

And we will need some tests :) If you cannot just let me know

@niden niden added the Enhancement label Dec 26, 2018

@niden niden added this to In progress in 4.0 Release via automation Dec 26, 2018

@ekmst ekmst force-pushed the ekmst:feature/tag-renderTitle branch from 5ea437e to 373b7f0 Dec 27, 2018

ekmst added some commits Dec 27, 2018

@ekmst

This comment has been minimized.

Copy link
Contributor Author

ekmst commented Dec 27, 2018

And we will need some tests :) If you cannot just let me know

@niden fixed :)

@niden

niden approved these changes Dec 27, 2018

@niden

This comment has been minimized.

Copy link
Member

niden commented Dec 27, 2018

@ekmst Thank you!

@niden niden merged commit 807f6db into phalcon:4.0.x Dec 27, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

4.0 Release automation moved this from In progress to Done Dec 27, 2018

@ekmst ekmst deleted the ekmst:feature/tag-renderTitle branch Dec 27, 2018

- Fixed `Phalcon\Mvc\Models` magic method (setter) is fixed for arrays [#13661](https://github.com/phalcon/cphalcon/issues/13661)
- Fixed `Phalcon\Mvc\Model::skipAttributes` and `Phalcon\Mvc\Model::allowEmptyColumns` allowEmptyStrings & skipAttributes repsect the column mapping. [#12975](https://github.com/phalcon/cphalcon/issues/12975), [#13477](https://github.com/phalcon/cphalcon/issues/13477)
- Changed the `Phalcon\Tag::renderTitle()` parameters such as `Phalcon\Tag::getTitle()`
- Changed the `Phalcon\Html\Tag::renderTitle()` parameters such as `Phalcon\Html\Tag::getTitle()`

This comment has been minimized.

@sergeyklay

sergeyklay Dec 29, 2018

Member

@niden Can you please move these lines to another section, e.g.

# [4.0.0-alpha2](https://github.com/phalcon/cphalcon/releases/tag/v4.0.0-alpha2) (2019-XX-XX)
## Changed
- Changed the `Phalcon\Tag::renderTitle()` parameters such as `Phalcon\Tag::getTitle()
- Changed the `Phalcon\Html\Tag::renderTitle()` parameters such as `Phalcon\Html\Tag::getTitle()`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment