New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the Phalcon\Version::get() to follow semantic versioning #13720

Merged
merged 3 commits into from Dec 30, 2018

Conversation

Projects
2 participants
@sergeyklay
Copy link
Member

sergeyklay commented Dec 30, 2018

Hello!

  • Type: new feature
  • Link to issue: -

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines.
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.

Small description of change: Changed the Phalcon\Version::get() to follow semantic versioning

Thanks

sergeyklay added some commits Dec 30, 2018

@sergeyklay sergeyklay changed the title Bump version Changed the Phalcon\Version::get() to follow semantic versioning Dec 30, 2018

@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 30, 2018

Codecov Report

Merging #13720 into 4.0.x will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            4.0.x   #13720      +/-   ##
==========================================
+ Coverage   65.15%   65.15%   +<.01%     
==========================================
  Files         396      396              
  Lines       88165    88169       +4     
==========================================
+ Hits        57440    57444       +4     
  Misses      30725    30725
Impacted Files Coverage Δ
ext/phalcon/version.zep.c 94.63% <0%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 606b2fc...6410538. Read the comment docs.

@sergeyklay sergeyklay requested a review from niden Dec 30, 2018

@sergeyklay sergeyklay added the Feature label Dec 30, 2018

@sergeyklay sergeyklay added this to the 4.0.0 milestone Dec 30, 2018

@sergeyklay sergeyklay added this to In progress in 4.0 Release via automation Dec 30, 2018

@sergeyklay sergeyklay self-assigned this Dec 30, 2018

@niden

niden approved these changes Dec 30, 2018

@niden

This comment has been minimized.

Copy link
Member

niden commented Dec 30, 2018

Rock and roll!

@niden niden merged commit a128f9a into 4.0.x Dec 30, 2018

5 checks passed

codecov/patch Coverage not affected when comparing 606b2fc...6410538
Details
codecov/project 65.15% (+<.01%) compared to 606b2fc
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

4.0 Release automation moved this from In progress to Done Dec 30, 2018

@sergeyklay sergeyklay deleted the feature/follow-semver branch Dec 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment