New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T13007 nativearray missing #13730

Merged
merged 4 commits into from Jan 5, 2019

Conversation

Projects
2 participants
@niden
Copy link
Member

niden commented Jan 4, 2019

Hello!

  • Type: new feature
  • Link to issue: #13007

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines?

  • I have checked that another pull request for this purpose does not exist.

  • I wrote some tests for this PR.

  • Added a new parameter in the constructor array triggerError. If set, then the component will trigger an error E_USER_ERROR if the key is not found.

  • Added notFound() method which returns the key requested if not found. The method can be overriden when extending the class, returning what the developer needs
    Thanks

niden added some commits Jan 4, 2019

@niden niden added the Enhancement label Jan 4, 2019

@niden niden added this to In progress in 4.0 Release via automation Jan 4, 2019

@niden

This comment has been minimized.

Copy link
Member

niden commented Jan 4, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 5, 2019

Codecov Report

Merging #13730 into 4.0.x will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            4.0.x   #13730      +/-   ##
==========================================
+ Coverage   65.52%   65.53%   +<.01%     
==========================================
  Files         396      396              
  Lines       88175    88208      +33     
==========================================
+ Hits        57775    57805      +30     
- Misses      30400    30403       +3
Impacted Files Coverage Δ
ext/phalcon/translate/adapter/nativearray.zep.c 86.13% <0%> (+2.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1bc3e8...556d20d. Read the comment docs.

@niden niden merged commit 556d20d into phalcon:4.0.x Jan 5, 2019

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

4.0 Release automation moved this from In progress to Done Jan 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment