New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.0.x Tests code cleanup #13734

merged 9 commits into from Jan 5, 2019


1 participant
Copy link

niden commented Jan 5, 2019


  • Type: code quality
  • Link to issue:

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines?
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.

PHPCS mostly


niden added some commits Dec 26, 2018

Merge remote-tracking branch 'upstream/master' into 4.0.x
* upstream/master:
  [4.0.x] - PHPCS fix
[4.0.x] - Merge remote-tracking branch 'upstream/4.0.x' into 4.0.x
* upstream/4.0.x:
  Updated/Refactored Libmemcached tests
  #13459: Created test for issue and updated result checking
  Fixed #13497 returning "empty" values as `null`
Revert "[4.0.x] -"
This reverts commit a828104.
Revert "Revert "[4.0.x] -""
This reverts commit a438074.
[4.0.x] - Merge remote-tracking branch 'upstream/4.0.x' into 4.0.x
* upstream/4.0.x:
  Minor fixes in docblocks
[4.0.x] - Merge remote-tracking branch 'upstream/4.0.x' into 4.0.x
* upstream/4.0.x:
  [#13007] - Correction to the changelog
  [#13007] - Updated the CHANGELOG
  [#13007] - Added notFound in the nativearray translate adapter

@niden niden added this to In progress in 4.0 Release via automation Jan 5, 2019

@niden niden merged commit e469aaa into phalcon:4.0.x Jan 5, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
continuous-integration/appveyor/pr AppVeyor build succeeded

4.0 Release automation moved this from In progress to Done Jan 5, 2019

niden added a commit to niden/cphalcon that referenced this pull request Jan 9, 2019

[4.0.x] - Merge remote-tracking branch 'upstream/4.0.x' into 4.0.x
* upstream/4.0.x:
  Fixed change logs [ci skip]
  Fixed change logs [ci skip]
  Fixed Security\SecurityCest
  Fixed Libmemcached test
  Fixed PHP version at composer.json
  Actualize .gitignore
  Update dev dependencies
  Cleaned up no longer needed CI scripts
  Show test output in compact style
  Fixed code style for Session\ManagerCest
  Simplify session status check
  Update change log to add link to the phalcon#13520
  Do not run phpcs on PHP 7.3
  Do not interact with _SESSION if the session has not been started
  Fixed Session\Manager to not interact with _SESSION
  Fixed session adapters to properly implement SessionHandlerInterface::write
  fixed acl docblock
  4.0.x Tests code cleanup (phalcon#13734)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment