New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed session adapters to properly implement SessionHandlerInterface::write #13746

Merged
merged 1 commit into from Jan 8, 2019

Conversation

Projects
2 participants
@sergeyklay
Copy link
Member

sergeyklay commented Jan 8, 2019

Hello!

  • Type: bug fix
  • Link to issue: #13718

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR

Small description of change:

Fixed session adapters to properly implement SessionHandlerInterface::write.

session_write_close(): Session callback expects true/false return value

Thanks

@niden niden added the Bug - Medium label Jan 8, 2019

@niden niden added this to In progress in 4.0 Release via automation Jan 8, 2019

@niden

niden approved these changes Jan 8, 2019

@sergeyklay sergeyklay merged commit 5564a81 into 4.0.x Jan 8, 2019

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

4.0 Release automation moved this from In progress to Done Jan 8, 2019

@sergeyklay sergeyklay deleted the fix/session-implementation branch Jan 8, 2019

@sergeyklay sergeyklay referenced this pull request Jan 8, 2019

Closed

Fixed session segmentation fault on start #13745

3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment