New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T13007 nativearray missing patch #13748

Merged
merged 13 commits into from Jan 10, 2019

Conversation

Projects
2 participants
@niden
Copy link
Member

niden commented Jan 9, 2019

Hello!

  • Type: bug fix
  • Link to issue: #13007

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines?
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.

Better implementation for triggerError

Thanks

niden added some commits Dec 26, 2018

Merge remote-tracking branch 'upstream/master' into 4.0.x
* upstream/master:
  [4.0.x] - PHPCS fix
[4.0.x] - Merge remote-tracking branch 'upstream/4.0.x' into 4.0.x
* upstream/4.0.x:
  Updated/Refactored Libmemcached tests
  #13459: Created test for issue and updated result checking
  Fixed #13497 returning "empty" values as `null`
Revert "[4.0.x] -"
This reverts commit a828104.
Revert "Revert "[4.0.x] -""
This reverts commit a438074.
[4.0.x] - Merge remote-tracking branch 'upstream/4.0.x' into 4.0.x
* upstream/4.0.x:
  Minor fixes in docblocks
[4.0.x] - Merge remote-tracking branch 'upstream/4.0.x' into 4.0.x
* upstream/4.0.x:
  [#13007] - Correction to the changelog
  [#13007] - Updated the CHANGELOG
  [#13007] - Added notFound in the nativearray translate adapter
[4.0.x] - Merge remote-tracking branch 'upstream/4.0.x' into 4.0.x
* upstream/4.0.x:
  Fixed change logs [ci skip]
  Fixed change logs [ci skip]
  Fixed Security\SecurityCest
  Fixed Libmemcached test
  Fixed PHP version at composer.json
  Actualize .gitignore
  Update dev dependencies
  Cleaned up no longer needed CI scripts
  Show test output in compact style
  Fixed code style for Session\ManagerCest
  Simplify session status check
  Update change log to add link to the #13520
  Do not run phpcs on PHP 7.3
  Do not interact with _SESSION if the session has not been started
  Fixed Session\Manager to not interact with _SESSION
  Fixed session adapters to properly implement SessionHandlerInterface::write
  fixed acl docblock
  4.0.x Tests code cleanup (#13734)

@niden niden added the Enhancement label Jan 9, 2019

@niden niden added this to In progress in 4.0 Release via automation Jan 9, 2019

@niden niden changed the base branch from master to 4.0.x Jan 9, 2019

@niden

This comment has been minimized.

Copy link
Member

niden commented Jan 9, 2019

@sergeyklay
Copy link
Member

sergeyklay left a comment

LGTM

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 9, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (4.0.x@0572b97). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             4.0.x   #13748   +/-   ##
========================================
  Coverage         ?   65.53%           
========================================
  Files            ?      396           
  Lines            ?    88242           
  Branches         ?        0           
========================================
  Hits             ?    57832           
  Misses           ?    30410           
  Partials         ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0572b97...2214150. Read the comment docs.

@niden niden merged commit d2185b2 into phalcon:4.0.x Jan 10, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

4.0 Release automation moved this from In progress to Done Jan 10, 2019

niden added a commit to niden/cphalcon that referenced this pull request Jan 10, 2019

[4.0.x] - Merge remote-tracking branch 'upstream/4.0.x' into 4.0.x
* upstream/4.0.x:
  T13007 nativearray missing patch (phalcon#13748)

@niden niden deleted the niden:T13007-nativearray-missing-patch branch Jan 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment