New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Removed no longer used PHP 5.x stuff from Volt parser #13752

Closed
wants to merge 9 commits into
base: 4.0.x
from

Conversation

Projects
None yet
2 participants
@sergeyklay
Copy link
Member

sergeyklay commented Jan 9, 2019

Hello!

  • Type: code quality | testing
  • Link to issue: -

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR

Small description of change:

  • Removed no longer used PHP 5.x stuff from Volt parser
  • Cleaned up and refactor Volt tests
  • Fixed C compiler warnings

Thanks

sergeyklay added some commits Jan 9, 2019

@sergeyklay sergeyklay self-assigned this Jan 9, 2019

@sergeyklay sergeyklay added this to In progress in 4.0 Release via automation Jan 9, 2019

@sergeyklay sergeyklay added this to the 4.0.0 milestone Jan 9, 2019

@niden

This comment has been minimized.

Copy link
Member

niden commented Jan 9, 2019

Looking good

sergeyklay added some commits Jan 9, 2019

@sergeyklay sergeyklay changed the title Removed no longer used PHP 5.x stuff from Volt parser [WIP] Removed no longer used PHP 5.x stuff from Volt parser Jan 9, 2019

sergeyklay added some commits Jan 9, 2019

@sergeyklay sergeyklay removed this from the 4.0.0 milestone Jan 9, 2019

@sergeyklay sergeyklay removed this from In progress in 4.0 Release Jan 9, 2019

@sergeyklay

This comment has been minimized.

Copy link
Member

sergeyklay commented Jan 9, 2019

Closed in favor of #13753, #13754 and #13755

@sergeyklay sergeyklay closed this Jan 9, 2019

@sergeyklay sergeyklay deleted the fix/volt-tests branch Jan 9, 2019

@sergeyklay sergeyklay removed their assignment Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment