New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed build for PHP 7.3 #13757

Merged
merged 4 commits into from Jan 10, 2019

Conversation

Projects
2 participants
@sergeyklay
Copy link
Member

sergeyklay commented Jan 10, 2019

Hello!

  • Type: bug fix
  • Link to issue: -

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR

Small description of change:

  • Use xdebug only with stable PHP
  • Fixed build on Travis CI
  • Fixed Phalcon\Cache\Backend\Apcu::get to remove irrelevant check

Thanks

@sergeyklay sergeyklay self-assigned this Jan 10, 2019

@sergeyklay sergeyklay added the Testing label Jan 10, 2019

@sergeyklay sergeyklay added this to In progress in 4.0 Release via automation Jan 10, 2019

@sergeyklay sergeyklay added this to the 4.0.0 milestone Jan 10, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 10, 2019

Codecov Report

Merging #13757 into 4.0.x will increase coverage by 0.32%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            4.0.x   #13757      +/-   ##
==========================================
+ Coverage   65.66%   65.99%   +0.32%     
==========================================
  Files         396      396              
  Lines       88244    88240       -4     
==========================================
+ Hits        57947    58234     +287     
+ Misses      30297    30006     -291
Impacted Files Coverage Δ
ext/phalcon/cache/backend/redis.zep.c 58.34% <0%> (-0.08%) ⬇️
ext/phalcon/di.zep.c 73.82% <0%> (+3.79%) ⬆️
ext/phalcon/config/adapter/yaml.zep.c 69.35% <0%> (+64.51%) ⬆️
ext/phalcon/cache/backend/apcu.zep.c 76.66% <0%> (+75.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db0ed22...ba83b6a. Read the comment docs.

@sergeyklay sergeyklay force-pushed the fix/use-proper-xdebug branch from 42fbf54 to 796925c Jan 10, 2019

@sergeyklay sergeyklay requested a review from niden Jan 10, 2019

@sergeyklay sergeyklay changed the title Use xdebug only with stable PHP Fixed build for PHP 7.3 Jan 10, 2019

@niden

niden approved these changes Jan 10, 2019

@niden

This comment has been minimized.

Copy link
Member

niden commented Jan 10, 2019

Rock and roll!

@sergeyklay sergeyklay merged commit 51bef6d into 4.0.x Jan 10, 2019

3 checks passed

codecov/patch Coverage not affected when comparing db0ed22...ba83b6a
Details
codecov/project 65.99% (+0.32%) compared to db0ed22
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

4.0 Release automation moved this from In progress to Done Jan 10, 2019

@sergeyklay sergeyklay deleted the fix/use-proper-xdebug branch Jan 10, 2019

@sergeyklay sergeyklay referenced this pull request Jan 10, 2019

Closed

PHP 7.3 support #13701

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment