Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T13687 debug hide vars #13833

Merged
merged 33 commits into from Feb 18, 2019

Conversation

Projects
4 participants
@niden
Copy link
Member

niden commented Feb 16, 2019

Hello!

  • Type: bug fix | new feature | code quality | documentation
  • Link to issue: #13687

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines?
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.

Small description of change:

Thanks

niden added some commits Jan 28, 2019

Merge remote-tracking branch 'upstream/4.0.x' into 4.0.x
* upstream/4.0.x:
  [4.0.x] - Added unicode flag for email filter
[4.0.x] - Merge remote-tracking branch 'upstream/4.0.x' into 4.0.x
* upstream/4.0.x:
  [#13488] - Removed commas that crept in the .env file
  [#13488] - Minor corection to debug; Added funcitonality for getting filtered vars; Added tests
  [#13488] - Initial changes for the feature; adding methods
[4.0.x] - Merge remote-tracking branch 'upstream/4.0.x' into 4.0.x
* upstream/4.0.x:
  Updated changelog
  Updated CFLAG default build param
  keep the actionName as set, do cache the methodName in `getActiveMethod` instead (use action mapping to cover Dispatcher `forward`ing case?)
  move formatter into setter
  give up on `camelize`, use a new approach
  unit tests
  Camel-case the action name (before call in handler)
  Correct pull request template
  Fix .editorconfig
  Amended .gitignore
  Bump version
  Fixed preparing release on AppVeyor
  Update change log
  Regenerated build
  Regenerated ext
  Updating the changelog
[4.0.x] - Merge remote-tracking branch 'upstream/4.0.x' into 4.0.x
* upstream/4.0.x:
  Updated the changelog
  [#13808] - Updating ext folder
  [#13808] - Adjusting tests
  [#13808] - Renaming ACL elements
[4.0.x] - Merge remote-tracking branch 'upstream/4.0.x' into 4.0.x
* upstream/4.0.x:
  Update CHANGELOG-4.0.md
  Updated changelog
  Added geSetMetaData test Modified some unit tests to use metaData
  Modified existing tests to work with the additional MetaData
  Modified Phalcon\Mvc\Model to use Phalcon\Message::setMetaData() instead of setModel()
  Added new MetaData variable to Phalcon\Message. Modified Phalcon\MessageInterface accordingly
  Corrected typo
[4.0.x] - Merge remote-tracking branch 'upstream/4.0.x' into 4.0.x
* upstream/4.0.x:
  [#2182] - Updated the changelog and PR template
  [#2182] - Added before/after compile events for Volt
  [#2182] - Removed some obsolete tests; Added tests for engine/render events
  Updated changelog
  fix tests
  change tests
  fix stan
  Add `Dispatcher::toCamelCase()` method
  [#13819] - Updated the changelog
  [#13819] - Removing css/js optimizers from the config
  [#13819] - Updating ext/
  [#13819] - Removed minifiers
  [#13819] - Marked tests as skipped
[4.0.x] - Merge remote-tracking branch 'upstream/4.0.x' into 4.0.x
* upstream/4.0.x:
  Allow Config::merge to accept a basic array. (#13830)

@niden niden added the Enhancement label Feb 16, 2019

@niden niden added this to In progress in 4.0 Release via automation Feb 16, 2019

@niden niden requested a review from sergeyklay Feb 16, 2019

niden added some commits Feb 17, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 17, 2019

Codecov Report

Merging #13833 into 4.0.x will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            4.0.x   #13833      +/-   ##
==========================================
- Coverage   66.18%   66.12%   -0.07%     
==========================================
  Files         448      448              
  Lines       89344    89442      +98     
==========================================
+ Hits        59134    59144      +10     
- Misses      30210    30298      +88
Impacted Files Coverage Δ
ext/phalcon/mvc/model.zep.c 66.76% <0%> (-0.06%) ⬇️
ext/phalcon/html/tag.zep.c 79.68% <0%> (-0.02%) ⬇️
ext/phalcon/session/manager.zep.c 95.01% <0%> (+0.02%) ⬆️
ext/phalcon/debug.zep.c 12.43% <0%> (+0.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4cd29d...03694d8. Read the comment docs.

niden added some commits Feb 17, 2019

[#13687] - Merge remote-tracking branch 'upstream/4.0.x' into T13687-…
…debug-hide-vars

* upstream/4.0.x:
  T13336 find first null (#13826)
  renamed phalcon\mvc\url to phalcon\url (#13831)

niden added some commits Feb 17, 2019

[#13687] - Merge remote-tracking branch 'upstream/4.0.x' into T13687-…
…debug-hide-vars

* upstream/4.0.x:
  Install MySQL 5.7 on Travis CI [skip appveyor] (#13835)
@niden

This comment has been minimized.

Copy link
Member Author

niden commented Feb 17, 2019

@sergeyklay this is ready for review. I will check appveyor in a separate branch to sync it properly with 4.0

@niden niden referenced this pull request Feb 17, 2019

Open

v4: Rewrite debug.md #2111

@CameronHall

This comment has been minimized.

Copy link
Member

CameronHall commented Feb 17, 2019

@niden does this only cover $_REQUEST and $_SERVER? Could we also cover $_ENV?

@sergeyklay
Copy link
Member

sergeyklay left a comment

LGTM

Show resolved Hide resolved ext/config.w32

let result["request"] = subArray,
area = Arr::get(blacklist, "server", []),
subArray = [];

This comment has been minimized.

@Jeckerson

Jeckerson Feb 18, 2019

Member

Why so many spaces between variables and = in this method?

This comment has been minimized.

@sergeyklay

sergeyklay Feb 18, 2019

Member

Space driven development :)

This comment has been minimized.

@niden

niden Feb 18, 2019

Author Member

The tabs on the left side throw the whole thing off. Everything is actually aligned properly (equal signs and vars)

@niden

This comment has been minimized.

Copy link
Member Author

niden commented Feb 18, 2019

@CameronHall The component only shows request and server, not env, this is why I did not touch that part.

@niden niden merged commit e427da5 into phalcon:4.0.x Feb 18, 2019

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

4.0 Release automation moved this from In progress to Done Feb 18, 2019

niden added a commit to niden/cphalcon that referenced this pull request Feb 19, 2019

[phalcon#11789] - Merge remote-tracking branch 'upstream/4.0.x' into …
…T11789-PSR-7

* upstream/4.0.x:
  4.0.x: adding missing method isSent to interface ResponseInterface (phalcon#13836)
  T13687 debug hide vars (phalcon#13833)

niden added a commit to niden/cphalcon that referenced this pull request Feb 22, 2019

[phalcon#13844] - Merge remote-tracking branch 'upstream/4.0.x' into …
…T13844-mcall-undefined-errors

* upstream/4.0.x:
  4.0.x: adding missing method isSent to interface ResponseInterface (phalcon#13836)
  T13687 debug hide vars (phalcon#13833)

niden added a commit to niden/cphalcon that referenced this pull request Feb 22, 2019

[4.0.x] - Merge remote-tracking branch 'upstream/4.0.x' into 4.0.x
* upstream/4.0.x:
  4.0.x: adding missing method isSent to interface ResponseInterface (phalcon#13836)
  T13687 debug hide vars (phalcon#13833)

@niden niden deleted the niden:T13687-debug-hide-vars branch Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.