Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.0.x: adding missing method isSent to interface ResponseInterface #13836

Merged
merged 2 commits into from Feb 18, 2019

Conversation

Projects
None yet
3 participants
@Idrinth
Copy link
Contributor

Idrinth commented Feb 18, 2019

Hello!

  • Type: bug fix
  • Link to issue: -

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines?
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.

Small description of change:

This is a followup to #13821, adding the missing method to the interface. Compare #13821 (comment)

@Idrinth Idrinth referenced this pull request Feb 18, 2019

Closed

preventing call to undefined method isSent #13821

2 of 3 tasks complete

@Idrinth Idrinth force-pushed the Idrinth:4.0.x branch from 0304a4e to c4f0c7d Feb 18, 2019

@Idrinth Idrinth marked this pull request as ready for review Feb 18, 2019

@Idrinth Idrinth changed the title adding missing method isSent to interface ResponseInterface 4.0.x: adding missing method isSent to interface ResponseInterface Feb 18, 2019

@sergeyklay
Copy link
Member

sergeyklay left a comment

Looks good to me. Could you update change log?

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 18, 2019

Codecov Report

Merging #13836 into 4.0.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            4.0.x   #13836   +/-   ##
=======================================
  Coverage   66.18%   66.18%           
=======================================
  Files         448      448           
  Lines       89344    89344           
=======================================
  Hits        59134    59134           
  Misses      30210    30210

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4cd29d...9d301e4. Read the comment docs.

@niden

niden approved these changes Feb 18, 2019

@niden niden merged commit b19d84a into phalcon:4.0.x Feb 18, 2019

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@niden

This comment has been minimized.

Copy link
Member

niden commented Feb 18, 2019

Thank you @Idrinth

dschissler added a commit to dschissler/cphalcon that referenced this pull request Feb 18, 2019

niden added a commit to niden/cphalcon that referenced this pull request Feb 19, 2019

[phalcon#11789] - Merge remote-tracking branch 'upstream/4.0.x' into …
…T11789-PSR-7

* upstream/4.0.x:
  4.0.x: adding missing method isSent to interface ResponseInterface (phalcon#13836)
  T13687 debug hide vars (phalcon#13833)

niden added a commit to niden/cphalcon that referenced this pull request Feb 22, 2019

[phalcon#13844] - Merge remote-tracking branch 'upstream/4.0.x' into …
…T13844-mcall-undefined-errors

* upstream/4.0.x:
  4.0.x: adding missing method isSent to interface ResponseInterface (phalcon#13836)
  T13687 debug hide vars (phalcon#13833)

niden added a commit to niden/cphalcon that referenced this pull request Feb 22, 2019

[4.0.x] - Merge remote-tracking branch 'upstream/4.0.x' into 4.0.x
* upstream/4.0.x:
  4.0.x: adding missing method isSent to interface ResponseInterface (phalcon#13836)
  T13687 debug hide vars (phalcon#13833)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.