Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo in comment #13874

Merged
merged 1 commit into from Mar 3, 2019

Conversation

Projects
None yet
2 participants
@challet
Copy link
Contributor

challet commented Mar 3, 2019

Hello!

  • Type: documentation

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines?
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.

Small description of change:

Fixing wrong name in a comment about the class being tested

Thanks

typo in comment
about the name of the class being tested

@challet challet changed the base branch from master to 4.0.x Mar 3, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 3, 2019

Codecov Report

Merging #13874 into 4.0.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            4.0.x   #13874   +/-   ##
=======================================
  Coverage   66.84%   66.84%           
=======================================
  Files         448      448           
  Lines       89067    89067           
=======================================
  Hits        59534    59534           
  Misses      29533    29533

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 749190b...51f7900. Read the comment docs.

@sergeyklay sergeyklay merged commit 8dc7fa5 into phalcon:4.0.x Mar 3, 2019

4 checks passed

codecov/patch Coverage not affected when comparing 749190b...51f7900
Details
codecov/project 66.84% remains the same compared to 749190b
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sergeyklay

This comment has been minimized.

Copy link
Member

sergeyklay commented Mar 3, 2019

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.