Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.0.0-alpha.3 #13876

Merged
merged 64 commits into from Mar 3, 2019

Conversation

Projects
None yet
10 participants
@sergeyklay
Copy link
Member

sergeyklay commented Mar 3, 2019

No description provided.

sergeyklay and others added some commits Feb 3, 2019

keep the actionName as set, do cache the methodName in `getActiveMeth…
…od` instead (use action mapping to cover Dispatcher `forward`ing case?)
Added new MetaData variable to Phalcon\Message.
Modified Phalcon\MessageInterface accordingly
Added geSetMetaData test
Modified some unit tests to use metaData

niden and others added some commits Feb 16, 2019

T13336 find first null (#13826)
* [4.0.x] - Added unicode flag for email filter

* [#13336] - Adjustments to handling parameters for findFirst with primary key

* [#13336] - Updated the changelog
T13687 debug hide vars (#13833)
* [4.0.x] - Added unicode flag for email filter

* [#13687] - Added testbed for quick testing using the server

* [#13687] - Set the Utility as static

* [#13687] - Adjusted tests

* [#13687] - Corrected the change to the Utility class

* [#13687] - Updating the changelog

* [#13687] - Added Helper/Arr

* [#13687] - Added tests for Arr

* [#13687] - Corrections to the helper

* [#13687] - Removing mysql 5.7 temporarily

* [#13687] - Trying xenial build

* [#13687] - Updating ext folder

* Revert "[#13687] - Updating ext folder"

This reverts commit f18a967.

* Revert "[#13687] - Trying xenial build"

This reverts commit 07da593.

* [#13687] - Refactored locations for url/utils

* [#13687] - Updated references to url/utils

* [#13687] - Trying the build with mysql5.7 again

* [#13687] - Trying a different installation for mysql 5.7

* [#13687] - Trying to get the installation going of mysql 5.7

* [#13687] - Trying something different

* [#13687] - Trying xenial

* [#13687] - Re-enabling mysql; removing memcached

* [#13687] - Adding again memcached in the setup

* [#13687] - Removing xenial
4.0.x: adding missing method isSent to interface ResponseInterface (#…
…13836)

* adding missing method to interface

* adding fix mention: ResponseInterface::isSent
T13844 mcall undefined errors (#13849)
* [4.0.x] - Added unicode flag for email filter

* [4.0.x] - Updating the ext folder

* [4.0.x] - Added Arr helper class

* Revert "[4.0.x] - Added Arr helper class"

This reverts commit f8153d3.

* Revert "[4.0.x] - Updating the ext folder"

This reverts commit 655eafe.

* [#13844] - Fixing mcall warnings in compilation

* [#13844] - Updating ext
T13364 beanstalk removal (#13850)
* [4.0.x] - Added unicode flag for email filter

* [4.0.x] - Updating the ext folder

* [4.0.x] - Added Arr helper class

* Revert "[4.0.x] - Added Arr helper class"

This reverts commit f8153d3.

* Revert "[4.0.x] - Updating the ext folder"

This reverts commit 655eafe.

* [#13364] - Bye bye beanstalk! We love you! Next version we will add a Queue adapter for more adaptations

* [#13364] - Updated the changelog
[#11926] Changed view engine service closures to no longer receive th… (
#13839)

* [#11926] Changed view engine service closures to no longer receive the dependency injector as the second parameter.

* Attempt to fix Volt engine integration test.

* Bind view service closures to the DI, fix more tests.

* Update CHANGELOG-4.0.md
Dispatcher handlercache (#13854)
* Change use of Phalcon\Dispatcher DI::wasFreshInstance to instead use a handler hash cache.

* Fix broken Phalcon syntax.

* Fix for invalid dispatcher handler.
Allow grouped config loader to determine adaptor from file extension. (
…#13762)

* Pass through string handling when adapter not set.

* Update changelog.

* Updated test for coverage of new feature but I doubt it conforms to standards (two tests doing one thing esspecially).

* Fix to use the right class name.

* Whitespace fix.

* Fix the build.

* Less of a handfull parameter passing.

* Switch to using empty string rather than null.
DI::get shared caching - a more comprehensive solution (#13846)
* Add DI::get shared caching.

* Change exception message to match test.

* Revert DI::get events manager check.

* Fix comment in DI.
Cleanup
this files have been removed.
Refactored security tests from SecurityCest (#13864)
Removed get/set di test
Removed DestroyTokenCest (covered by CheckTokenCest)
Removed GetSessionTokenCest (covered by getRequestToken)
Removed GetTokenCest (covered by GetTokenAndKeyCest)
Removed GetTokenKeyCest (covered by GetTokenAndKeyCest)
Removed GetWorkFactorCest (covered by GetSetWorkFactorCest)
Removed GetDefaultHashCest (covered by GetSetDefaultHashCest)
Removed SetRandomBytesCest (covered by GetSetRandomBytesCest)
Update boxfile.7.2.yml (#13859)
Tests showing warning that apc needs to be enabled.
Enabled apc in php.ini
Fixed #13858 - Nanobox config fails for php 7.3 (#13866)
* Removed xdebug (will be back when Xdebug 2.7.0 is stable)
Enabled apc

* Added xdebug in comments
Pdo radicaloptions (#13862)
* Redesign PDO adapter setup.

* Refactor Phalcon\Db\Adapter\Pdo::connect

* Add dsnAttributes default starting point point to empty array.

* Simplify PDO connect since the descriptor root level is now longer processed.

* Redesign Pdo::connect to use base level of descriptor as dsn attributes.

* Add debug message to Pdo::connect.

* More debug messages.

* More debug messages.

* Unset dbname descriptor in sqlite pdo adapter after using its value for the dsn striing.

* Remove debug messages.

* Add flexibility to the PDO Sqlite adapter so that the database (file) can be specified using either 'dbname' or with the 'dsn' attributes.

* Unset dialectClass in pdo::connect.

* Remove PDO options sniffing.
typo in comment
about the name of the class being tested

@sergeyklay sergeyklay added the Release label Mar 3, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 3, 2019

Codecov Report

Merging #13876 into master will increase coverage by 0.57%.
The diff coverage is 68.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13876      +/-   ##
==========================================
+ Coverage   66.26%   66.84%   +0.57%     
==========================================
  Files         452      448       -4     
  Lines       89771    89067     -704     
==========================================
+ Hits        59486    59534      +48     
+ Misses      30285    29533     -752
Impacted Files Coverage Δ
ext/phalcon/forms/element/select.zep.c 85.13% <ø> (ø) ⬆️
ext/phalcon/mvc/router/annotations.zep.c 69.48% <ø> (ø) ⬆️
...on/mvc/model/metadata/strategy/introspection.zep.c 83.9% <ø> (ø) ⬆️
ext/phalcon/logger/adapter/stream.zep.c 78.21% <ø> (ø) ⬆️
ext/phalcon/mvc/model/transaction.zep.c 69.94% <ø> (ø) ⬆️
ext/phalcon/filter/sanitize/stringval.zep.c 100% <ø> (ø) ⬆️
ext/phalcon/mvc/model/metadata/session.zep.c 5.4% <ø> (ø) ⬆️
ext/phalcon/validation/validator/exclusionin.zep.c 85.71% <ø> (ø) ⬆️
ext/phalcon/validation/validator/alpha.zep.c 100% <ø> (ø) ⬆️
ext/phalcon/mvc/model/metadata/libmemcached.zep.c 88.23% <ø> (ø) ⬆️
... and 234 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 171b6cd...478e7da. Read the comment docs.

@sergeyklay sergeyklay merged commit 9fae862 into master Mar 3, 2019

6 checks passed

codecov/patch 68.94% of diff hit (target 66.26%)
Details
codecov/project 66.84% (+0.57%) compared to 171b6cd
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.