Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed compatibility issue. #13911

Merged
merged 1 commit into from Mar 22, 2019

Conversation

Projects
4 participants
@shum0531
Copy link
Contributor

commented Mar 21, 2019

Hello!

  • Type: improvement
  • Link to issue:

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I updated the CHANGELOG

Small description of change:

setImageAlpha () - fills the alpha channel with black before execution.
evaluateImage () is the best compatibility.

Thanks

Fixed compatibility issue.
setImageAlpha () - fills the alpha channel with black before execution.
valuImage () is the best compatibility.
@codecov

This comment has been minimized.

Copy link

commented Mar 21, 2019

Codecov Report

Merging #13911 into 4.0.x will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            4.0.x   #13911      +/-   ##
==========================================
+ Coverage   67.85%   67.85%   +<.01%     
==========================================
  Files         468      468              
  Lines       93380    93378       -2     
==========================================
  Hits        63365    63365              
+ Misses      30015    30013       -2
Impacted Files Coverage Δ
ext/phalcon/image/adapter/imagick.zep.c 77.51% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2ff644...c073be8. Read the comment docs.

@niden

This comment has been minimized.

Copy link
Member

commented Mar 21, 2019

@shum0531 Can you please add a line to the CHANGELOG-v4 of what this PR does?

shum0531 added a commit to shum0531/cphalcon that referenced this pull request Mar 22, 2019

shum0531 added a commit to shum0531/cphalcon that referenced this pull request Mar 22, 2019

@niden niden merged commit 02b86cc into phalcon:4.0.x Mar 22, 2019

4 checks passed

codecov/patch Coverage not affected when comparing c2ff644...c073be8
Details
codecov/project 67.85% (+<.01%) compared to c2ff644
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@niden

This comment has been minimized.

Copy link
Member

commented Mar 22, 2019

Thank you @shum0531

@niden niden added the Enhancement label Mar 22, 2019

@niden niden added this to In progress in 4.0 Release via automation Mar 22, 2019

@niden niden moved this from In progress to Done in 4.0 Release Mar 22, 2019

sergeyklay added a commit that referenced this pull request Mar 22, 2019

@niden niden added the Docs needed label Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.