Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed pointless property and variables from Volt compiler #13925

Merged
merged 3 commits into from Apr 5, 2019

Conversation

Projects
4 participants
@SidRoberts
Copy link
Member

commented Apr 1, 2019

Hello!

  • Type: code quality
  • Link to issue:

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • [-] I wrote some tests for this PR
  • [-] I updated the CHANGELOG

Previously a variable was "cached" as a property.

@codecov

This comment has been minimized.

Copy link

commented Apr 1, 2019

Codecov Report

Merging #13925 into 4.0.x will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            4.0.x   #13925      +/-   ##
==========================================
- Coverage   67.63%   67.63%   -0.01%     
==========================================
  Files         469      469              
  Lines       94345    94340       -5     
==========================================
- Hits        63814    63809       -5     
  Misses      30531    30531
Impacted Files Coverage Δ
ext/phalcon/mvc/view/engine/volt/compiler.zep.c 66.34% <0%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23f49d2...d262a5d. Read the comment docs.

@niden

This comment has been minimized.

Copy link
Member

commented Apr 1, 2019

Can you add an entry in the CHANGELOG please @SidRoberts

@SidRoberts SidRoberts force-pushed the SidRoberts:patch-4 branch from 3f5f811 to d262a5d Apr 5, 2019

@SidRoberts

This comment has been minimized.

Copy link
Member Author

commented Apr 5, 2019

@niden Changelog updated and rebased to avoid conflicts.

@niden niden added the Enhancement label Apr 5, 2019

@niden niden added this to In progress in 4.0 Release via automation Apr 5, 2019

@niden niden merged commit 814def6 into phalcon:4.0.x Apr 5, 2019

3 of 4 checks passed

codecov/project 67.63% (-0.01%) compared to 23f49d2
Details
codecov/patch Coverage not affected when comparing 23f49d2...d262a5d
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

4.0 Release automation moved this from In progress to Done Apr 5, 2019

@niden

This comment has been minimized.

Copy link
Member

commented Apr 5, 2019

@SidRoberts Thank you!

@SidRoberts SidRoberts deleted the SidRoberts:patch-4 branch Apr 5, 2019

@niden niden added the Docs needed label Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.