Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored SoftDelete model behaviour. #13930

Merged
merged 5 commits into from Apr 4, 2019

Conversation

Projects
4 participants
@SidRoberts
Copy link
Member

commented Apr 1, 2019

Hello!

  • Type: code quality
  • Link to issue:

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • [-] I wrote some tests for this PR
  • [-] I updated the CHANGELOG

Refactored SoftDelete model behaviour.

@codecov

This comment has been minimized.

Copy link

commented Apr 1, 2019

Codecov Report

Merging #13930 into 4.0.x will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            4.0.x   #13930      +/-   ##
==========================================
- Coverage   67.63%   67.63%   -0.01%     
==========================================
  Files         469      469              
  Lines       94344    94348       +4     
==========================================
+ Hits        63811    63812       +1     
- Misses      30533    30536       +3
Impacted Files Coverage Δ
ext/phalcon/mvc/model/behavior/softdelete.zep.c 77.77% <0%> (-0.64%) ⬇️
...t/phalcon/mvc/collection/behavior/softdelete.zep.c 4.47% <0%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56e0212...6752800. Read the comment docs.

@wajdijurry

This comment has been minimized.

Copy link

commented Apr 1, 2019

Good job 👍
I hope that Mvc\Collection\Behaviors\SoftDelete is refactored too, since the method "beforeDelete" is not being executed on delete.

@SidRoberts

This comment has been minimized.

Copy link
Member Author

commented Apr 1, 2019

@wajdijurry Good point, I completely forgot about that class. Fixed in 38efbbf.

@niden

This comment has been minimized.

Copy link
Member

commented Apr 1, 2019

@SidRoberts can you add an entry to the CHANGELOG please?

@niden niden added the Bug - Low label Apr 1, 2019

@niden niden added this to In progress in 4.0 Release via automation Apr 1, 2019

@SidRoberts SidRoberts dismissed stale reviews from sergeyklay and niden via f740303 Apr 2, 2019

@niden

niden approved these changes Apr 4, 2019

@niden niden merged commit 38fa0a7 into phalcon:4.0.x Apr 4, 2019

3 of 4 checks passed

codecov/project 67.63% (-0.01%) compared to 56e0212
Details
codecov/patch Coverage not affected when comparing 56e0212...6752800
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

4.0 Release automation moved this from In progress to Done Apr 4, 2019

@niden

This comment has been minimized.

Copy link
Member

commented Apr 4, 2019

Thank you @SidRoberts

@SidRoberts SidRoberts deleted the SidRoberts:softdelete branch Apr 4, 2019

@niden niden added the Docs needed label Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.