Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Collection::isInitialized() #13931

Merged
merged 3 commits into from Apr 2, 2019

Conversation

Projects
4 participants
@SidRoberts
Copy link
Member

commented Apr 1, 2019

Hello!

  • Type: bug fix
  • Link to issue:

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • [-] I wrote some tests for this PR
  • I updated the CHANGELOG

Previously, initialize() would store a list of the initialized collections in the this->initialized array. It stored the class name as is; Models\Users would be stored as "Models\Users". However, isInitialized() would check for an all lowercase version ("models\users").

I've also edited the method signature of isInitialized() by renaming modelName to className as it is a better description of what the variable is.

@codecov

This comment has been minimized.

Copy link

commented Apr 1, 2019

Codecov Report

Merging #13931 into 4.0.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            4.0.x   #13931   +/-   ##
=======================================
  Coverage   67.63%   67.63%           
=======================================
  Files         469      469           
  Lines       94344    94344           
=======================================
  Hits        63811    63811           
  Misses      30533    30533

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d5cd10...7027103. Read the comment docs.

Show resolved Hide resolved CHANGELOG-4.0.md Outdated
Update CHANGELOG-4.0.md
Co-Authored-By: SidRoberts <sid@sidroberts.co.uk>

@SidRoberts SidRoberts dismissed stale reviews from sergeyklay and Jeckerson via fae64f9 Apr 1, 2019

@sergeyklay sergeyklay merged commit 56e0212 into phalcon:4.0.x Apr 2, 2019

4 checks passed

codecov/patch Coverage not affected when comparing 4d5cd10...7027103
Details
codecov/project 67.63% remains the same compared to 4d5cd10
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sergeyklay

This comment has been minimized.

Copy link
Member

commented Apr 2, 2019

Thank you

@SidRoberts SidRoberts deleted the SidRoberts:model-initialize branch Apr 2, 2019

@niden niden added this to In progress in 4.0 Release via automation Apr 5, 2019

@niden niden moved this from In progress to Done in 4.0 Release Apr 5, 2019

@niden niden added the Docs needed label Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.