Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispatcher::forward() and Dispatcher::setParams() now require an array as a parameter #13935

Merged
merged 2 commits into from Apr 4, 2019

Conversation

Projects
3 participants
@SidRoberts
Copy link
Member

commented Apr 2, 2019

Hello!

  • Type: code quality
  • Link to issue:

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • [-] I wrote some tests for this PR
  • I updated the CHANGELOG

Small description of change:

Thanks

@codecov

This comment has been minimized.

Copy link

commented Apr 2, 2019

Codecov Report

Merging #13935 into 4.0.x will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            4.0.x   #13935      +/-   ##
==========================================
+ Coverage   67.63%   67.64%   +<.01%     
==========================================
  Files         469      469              
  Lines       94348    94344       -4     
==========================================
+ Hits        63812    63815       +3     
+ Misses      30536    30529       -7
Impacted Files Coverage Δ
...t/phalcon/mvc/collection/behavior/softdelete.zep.c 4.61% <0%> (+0.13%) ⬆️
ext/phalcon/dispatcher.zep.c 83.85% <0%> (+0.39%) ⬆️
ext/phalcon/mvc/model/behavior/softdelete.zep.c 78.4% <0%> (+0.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6fd8a2...a852a31. Read the comment docs.

@niden niden added this to In progress in 4.0 Release via automation Apr 4, 2019

@niden

niden approved these changes Apr 4, 2019

@niden niden merged commit 73ebc46 into phalcon:4.0.x Apr 4, 2019

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

4.0 Release automation moved this from In progress to Done Apr 4, 2019

@niden

This comment has been minimized.

Copy link
Member

commented Apr 4, 2019

Thank you @SidRoberts

@SidRoberts SidRoberts deleted the SidRoberts:dispatcher-forward branch Apr 4, 2019

@niden niden added the Docs needed label Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.