Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFR] - added description property to Cli\Router\Route #13936

Merged
merged 6 commits into from Apr 5, 2019

Conversation

Projects
4 participants
@ekmst
Copy link
Contributor

commented Apr 2, 2019

Hello!

  • Type: new feature
  • Link to issue:

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I updated the CHANGELOG

Small description of change: added description property to Cli\Router\Route

Usage:

$router = new \Phalcon\Cli\Router(false);
$router->add('test')->setName('testName')->setDescription('testDescription');
$router->add('test1')->setName('testName1')->setDescription('testDescription1');
$router->add('test2')->setName('testName2')->setDescription('testDescription2');

foreach ($router->getRoutes() as $route) {
    printf("%s    %s\n", $route->getName(), $route->getDescription());
}
$./phalconcli
Available command or tasks:
   testName      testDescription
   testName1     testDescription1
   testName2     testDescription2

Thanks

@codecov

This comment has been minimized.

Copy link

commented Apr 2, 2019

Codecov Report

Merging #13936 into 4.0.x will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            4.0.x   #13936      +/-   ##
==========================================
+ Coverage   67.63%   67.64%   +<.01%     
==========================================
  Files         469      469              
  Lines       94345    94364      +19     
==========================================
+ Hits        63814    63835      +21     
+ Misses      30531    30529       -2
Impacted Files Coverage Δ
ext/phalcon/cli/router/route.zep.c 84.52% <0%> (+0.34%) ⬆️
ext/phalcon/cli/router.zep.c 82.66% <0%> (+0.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23f49d2...76bedfc. Read the comment docs.

@ekmst

This comment has been minimized.

Copy link
Contributor Author

commented Apr 2, 2019

@Jeckerson done

Show resolved Hide resolved phalcon/Cli/Router/RouteInterface.zep Outdated
Show resolved Hide resolved phalcon/Cli/Router/Route.zep Outdated

@sergeyklay sergeyklay dismissed stale reviews from Jeckerson and themself via 86e09a5 Apr 4, 2019

sergeyklay added some commits Apr 4, 2019

@niden niden merged commit 55ee73d into phalcon:4.0.x Apr 5, 2019

4 checks passed

codecov/patch Coverage not affected when comparing 23f49d2...76bedfc
Details
codecov/project 67.64% (+<.01%) compared to 23f49d2
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@niden

This comment has been minimized.

Copy link
Member

commented Apr 5, 2019

Thank you @ekmst

@niden niden added this to In progress in 4.0 Release via automation Apr 5, 2019

@niden niden added the Breaks BC label Apr 5, 2019

@niden niden moved this from In progress to Done in 4.0 Release Apr 5, 2019

@ekmst ekmst deleted the ekmst:feature/cli-task-description branch Apr 6, 2019

SidRoberts added a commit to SidRoberts/cphalcon that referenced this pull request Apr 6, 2019

SidRoberts added a commit to SidRoberts/cphalcon that referenced this pull request Apr 6, 2019

SidRoberts added a commit to SidRoberts/cphalcon that referenced this pull request Apr 6, 2019

@niden niden added the Docs needed label Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.