Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phalcon\Translate\InterpolatorInterface now only accepts placeholder arrays #13939

merged 2 commits into from Apr 4, 2019


3 participants
Copy link

commented Apr 3, 2019


  • Type: code quality
  • Link to issue:

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • [-] I wrote some tests for this PR
  • I updated the CHANGELOG

The parameter typehint was not strong enough. 馃槈


This comment has been minimized.

Copy link

commented Apr 3, 2019

Codecov Report

Merging #13939 into 4.0.x will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            4.0.x   #13939      +/-   ##
- Coverage   67.63%   67.63%   -0.01%     
  Files         469      469              
  Lines       94348    94337      -11     
- Hits        63812    63804       -8     
+ Misses      30536    30533       -3
Impacted Files Coverage 螖
.../phalcon/translate/interpolator/indexedarray.zep.c 79.41% <0%> (-1.67%) 猬囷笍
...lcon/translate/interpolator/associativearray.zep.c 83.33% <0%> (-1.45%) 猬囷笍
...t/phalcon/mvc/collection/behavior/softdelete.zep.c 4.61% <0%> (+0.13%) 猬嗭笍
ext/phalcon/mvc/model/behavior/softdelete.zep.c 78.4% <0%> (+0.63%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 73ebc46...af474db. Read the comment docs.

@niden niden added this to In progress in 4.0 Release via automation Apr 4, 2019

@niden niden dismissed stale reviews from Jeckerson and themself via af474db Apr 4, 2019


niden approved these changes Apr 4, 2019

@niden niden merged commit 23f49d2 into phalcon:4.0.x Apr 4, 2019

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
continuous-integration/travis-ci/pr The Travis CI build is in progress

4.0 Release automation moved this from In progress to Done Apr 4, 2019


This comment has been minimized.

Copy link

commented Apr 4, 2019

Thank you @SidRoberts

@SidRoberts SidRoberts deleted the SidRoberts:interpolator branch Apr 4, 2019

@niden niden added the Docs needed label Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.