Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T13947 model interface #13948

Merged
merged 5 commits into from Apr 6, 2019
Merged

T13947 model interface #13948

merged 5 commits into from Apr 6, 2019

Conversation

niden
Copy link
Sponsor Member

@niden niden commented Apr 5, 2019

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I updated the CHANGELOG

Small description of change:

Thanks

@niden niden requested a review from sergeyklay April 5, 2019 18:00
@niden niden added Bug - Medium breaks bc Functionality that breaks Backwards Compatibility labels Apr 5, 2019
@niden niden added this to In progress in 4.0.0 Release via automation Apr 5, 2019
@niden niden changed the base branch from master to 4.0.x April 5, 2019 18:01
@codecov
Copy link

codecov bot commented Apr 5, 2019

Codecov Report

Merging #13948 into 4.0.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            4.0.x   #13948   +/-   ##
=======================================
  Coverage   67.64%   67.64%           
=======================================
  Files         469      469           
  Lines       94350    94350           
=======================================
  Hits        63821    63821           
  Misses      30529    30529

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1616b34...d111535. Read the comment docs.

@niden niden merged commit 4054dae into phalcon:4.0.x Apr 6, 2019
4.0.0 Release automation moved this from In progress to Done Apr 6, 2019
@niden niden added the documentation Documentation required label Apr 9, 2019
@niden niden added 4.0 and removed documentation Documentation required labels Oct 13, 2019
@niden niden added bug A bug report status: medium Medium and removed Bug - Medium labels Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaks bc Functionality that breaks Backwards Compatibility bug A bug report status: medium Medium
Projects
No open projects
4.0.0 Release
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants