Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected Volt option variables (fixes #13968) #13971

Merged
merged 2 commits into from Apr 14, 2019

Conversation

Projects
3 participants
@SidRoberts
Copy link
Member

commented Apr 14, 2019

Hello!

  • Type: bug fix
  • Link to issue: #13968

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • [-] I wrote some tests for this PR
  • [-] I updated the CHANGELOG

Small description of change:

Thanks

@codecov

This comment has been minimized.

Copy link

commented Apr 14, 2019

Codecov Report

Merging #13971 into 4.0.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            4.0.x   #13971   +/-   ##
=======================================
  Coverage   67.87%   67.87%           
=======================================
  Files         469      469           
  Lines       94315    94315           
=======================================
  Hits        64014    64014           
  Misses      30301    30301

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd3e523...09d6056. Read the comment docs.

@sergeyklay

This comment has been minimized.

Copy link
Member

commented Apr 14, 2019

@SidRoberts Could you please update change log

@sergeyklay sergeyklay added this to In progress in 4.0 Release via automation Apr 14, 2019

@sergeyklay sergeyklay added this to the 4.0.0 milestone Apr 14, 2019

@SidRoberts SidRoberts force-pushed the SidRoberts:volt-options branch from 1755706 to 66b8495 Apr 14, 2019

@niden niden merged commit ebe62f7 into phalcon:4.0.x Apr 14, 2019

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

4.0 Release automation moved this from In progress to Done Apr 14, 2019

@niden

This comment has been minimized.

Copy link
Member

commented Apr 14, 2019

Thank you @SidRoberts

@SidRoberts SidRoberts deleted the SidRoberts:volt-options branch Apr 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.