Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed Paginator\Adapter::getPaginate() to paginate() #13973

Merged
merged 1 commit into from Apr 14, 2019

Conversation

Projects
3 participants
@SidRoberts
Copy link
Member

commented Apr 14, 2019

See 4f5381b

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • [-] I wrote some tests for this PR
  • [-] I updated the CHANGELOG

Small description of change:

Thanks

@codecov

This comment has been minimized.

Copy link

commented Apr 14, 2019

Codecov Report

Merging #13973 into 4.0.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            4.0.x   #13973   +/-   ##
=======================================
  Coverage   67.87%   67.87%           
=======================================
  Files         469      469           
  Lines       94315    94315           
=======================================
  Hits        64014    64014           
  Misses      30301    30301

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b14982c...99adafc. Read the comment docs.

@sergeyklay sergeyklay added this to In progress in 4.0 Release via automation Apr 14, 2019

@sergeyklay sergeyklay added this to the 4.0.0 milestone Apr 14, 2019

@sergeyklay

This comment has been minimized.

Copy link
Member

commented Apr 14, 2019

@SidRoberts Should we update change log as well ?

@SidRoberts

This comment has been minimized.

Copy link
Member Author

commented Apr 14, 2019

@sergeyklay Update alpha.5 or alpha.1?

@sergeyklay

This comment has been minimized.

Copy link
Member

commented Apr 14, 2019

@SidRoberts alpha.5 please. Also feel free to mention version this change was actually made (even by mistake or wrongly).

@SidRoberts SidRoberts force-pushed the SidRoberts:paginator-getpaginate branch from d17ecca to 99adafc Apr 14, 2019

@niden

niden approved these changes Apr 14, 2019

@niden niden merged commit 65f34ee into phalcon:4.0.x Apr 14, 2019

4 checks passed

codecov/patch Coverage not affected when comparing b14982c...99adafc
Details
codecov/project 67.87% remains the same compared to b14982c
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

4.0 Release automation moved this from In progress to Done Apr 14, 2019

@niden

This comment has been minimized.

Copy link
Member

commented Apr 14, 2019

Thank you @SidRoberts

@SidRoberts SidRoberts deleted the SidRoberts:paginator-getpaginate branch Apr 14, 2019

@niden niden added the Docs needed label May 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.