Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Criteria::limit() now takes 'offset' as an integer. #13977

Merged
merged 1 commit into from Apr 15, 2019

Conversation

Projects
4 participants
@SidRoberts
Copy link
Member

commented Apr 14, 2019

Hello!

  • Type: code quality
  • Link to issue:

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • [-] I wrote some tests for this PR
  • I updated the CHANGELOG

Small description of change:

Thanks

@sergeyklay sergeyklay added this to In progress in 4.0 Release via automation Apr 14, 2019

@sergeyklay sergeyklay added this to the 4.0.0 milestone Apr 14, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 14, 2019

Codecov Report

Merging #13977 into 4.0.x will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            4.0.x   #13977      +/-   ##
==========================================
- Coverage   67.88%   67.88%   -0.01%     
==========================================
  Files         469      469              
  Lines       94314    94316       +2     
==========================================
- Hits        64027    64024       -3     
- Misses      30287    30292       +5
Impacted Files Coverage Δ
ext/phalcon/mvc/model/criteria.zep.c 34% <0%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5343ceb...f725d0c. Read the comment docs.

@niden niden added the Enhancement label Apr 14, 2019

@niden

This comment has been minimized.

Copy link
Member

commented Apr 14, 2019

@SidRoberts mind rebasing please?

@SidRoberts SidRoberts force-pushed the SidRoberts:criteria-limit branch from 1480f48 to f725d0c Apr 14, 2019

@niden niden added the Breaks BC label Apr 15, 2019

@niden

niden approved these changes Apr 15, 2019

@niden niden merged commit ead73be into phalcon:4.0.x Apr 15, 2019

3 of 4 checks passed

codecov/project 67.88% (-0.01%) compared to 5343ceb
Details
codecov/patch Coverage not affected when comparing 5343ceb...f725d0c
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

4.0 Release automation moved this from In progress to Done Apr 15, 2019

@niden

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

Thank you @SidRoberts

@niden niden added the Docs needed label Apr 15, 2019

SidRoberts added a commit to SidRoberts/phalcon-docs that referenced this pull request Apr 15, 2019

@SidRoberts SidRoberts deleted the SidRoberts:criteria-limit branch Apr 15, 2019

CameronHall added a commit to phalcon/docs that referenced this pull request Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.