Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing ModelsManager get/setModelSource to be overrideable #13987

Merged

Conversation

Projects
3 participants
@zsilbi
Copy link
Contributor

commented Apr 15, 2019

Hello!

  • Type: new feature
  • Link to issue: #13986

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I updated the CHANGELOG

Small description of change:

Changed getModelSource() to call setModelSource() when storing the source of the model.

Thanks

zsilbi and others added some commits Apr 15, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 15, 2019

Codecov Report

Merging #13987 into 4.0.x will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            4.0.x   #13987      +/-   ##
==========================================
+ Coverage   67.89%   67.89%   +<.01%     
==========================================
  Files         469      469              
  Lines       94292    94293       +1     
==========================================
+ Hits        64017    64018       +1     
  Misses      30275    30275
Impacted Files Coverage Δ
ext/phalcon/mvc/model/manager.zep.c 60.27% <0%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2972f0e...a7f6f36. Read the comment docs.

@sergeyklay

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

@zsilbi Could you please update change log

Németh Balázs

@sergeyklay sergeyklay added this to In progress in 4.0 Release via automation Apr 16, 2019

@sergeyklay sergeyklay added this to the 4.0.0 milestone Apr 16, 2019

@sergeyklay sergeyklay merged commit 852e792 into phalcon:4.0.x Apr 16, 2019

4 checks passed

codecov/patch Coverage not affected when comparing 2972f0e...a7f6f36
Details
codecov/project 67.89% (+<.01%) compared to 2972f0e
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

4.0 Release automation moved this from In progress to Done Apr 16, 2019

@sergeyklay

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

Thank you

@zsilbi zsilbi deleted the zsilbi:T13986-modelsmanager-modelsource-logic branch Apr 16, 2019

@niden niden added the Docs needed label May 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.