Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The property 'options' is always an array in Model Relations. #13989

Merged
merged 2 commits into from Apr 23, 2019

Conversation

Projects
4 participants
@SidRoberts
Copy link
Member

commented Apr 15, 2019

Hello!

  • Type: code quality
  • Link to issue:

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I updated the CHANGELOG

Small description of change:

Thanks

@codecov

This comment has been minimized.

Copy link

commented Apr 15, 2019

Codecov Report

Merging #13989 into 4.0.x will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            4.0.x   #13989      +/-   ##
==========================================
+ Coverage   67.92%   67.94%   +0.01%     
==========================================
  Files         469      469              
  Lines       94258    94255       -3     
==========================================
+ Hits        64027    64043      +16     
+ Misses      30231    30212      -19
Impacted Files Coverage Δ
ext/phalcon/mvc/model/relation.zep.c 84.93% <0%> (+10.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85a60f2...e0a3ed1. Read the comment docs.

@sergeyklay

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

@SidRoberts Could you please rebase

@SidRoberts SidRoberts force-pushed the SidRoberts:model-relation branch 4 times, most recently from 14ba426 to 76dd504 Apr 15, 2019

@SidRoberts SidRoberts force-pushed the SidRoberts:model-relation branch from 76dd504 to e0a3ed1 Apr 18, 2019

@niden niden added this to In progress in 4.0 Release via automation Apr 23, 2019

@niden niden merged commit 357293f into phalcon:4.0.x Apr 23, 2019

4 checks passed

codecov/patch Coverage not affected when comparing 85a60f2...e0a3ed1
Details
codecov/project 67.94% (+0.01%) compared to 85a60f2
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

4.0 Release automation moved this from In progress to Done Apr 23, 2019

@niden

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

Thank you @SidRoberts

@SidRoberts SidRoberts deleted the SidRoberts:model-relation branch Jun 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.