Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added addConnect(), addPurge() and addTrace() to Router Group #14001

Merged
merged 3 commits into from Apr 19, 2019

Conversation

Projects
3 participants
@SidRoberts
Copy link
Member

commented Apr 17, 2019

Hello!

  • Type: new feature
  • Link to issue:

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • [-] I wrote some tests for this PR
  • I updated the CHANGELOG

They exist in the Router so I assume the Router Group was forgotten about.

@codecov

This comment has been minimized.

Copy link

commented Apr 17, 2019

Codecov Report

Merging #14001 into 4.0.x will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            4.0.x   #14001      +/-   ##
==========================================
+ Coverage   67.92%      68%   +0.08%     
==========================================
  Files         469      469              
  Lines       94255    94327      +72     
==========================================
+ Hits        64019    64148     +129     
+ Misses      30236    30179      -57
Impacted Files Coverage Δ
ext/phalcon/mvc/router/group.zep.c 60.8% <0%> (+26.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77ef143...016b443. Read the comment docs.

SidRoberts added a commit to SidRoberts/phalcon-docs that referenced this pull request Apr 17, 2019

@SidRoberts SidRoberts force-pushed the SidRoberts:router-group-2 branch from 75a8dc6 to 016b443 Apr 18, 2019

@niden niden added this to In progress in 4.0 Release via automation Apr 19, 2019

@niden

niden approved these changes Apr 19, 2019

@niden niden merged commit 23e92d3 into phalcon:4.0.x Apr 19, 2019

4 checks passed

codecov/patch Coverage not affected when comparing 77ef143...016b443
Details
codecov/project 68% (+0.08%) compared to 77ef143
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

4.0 Release automation moved this from In progress to Done Apr 19, 2019

@niden

This comment has been minimized.

Copy link
Member

commented Apr 19, 2019

Thank you @SidRoberts

niden added a commit to phalcon/docs that referenced this pull request Apr 19, 2019

@SidRoberts SidRoberts deleted the SidRoberts:router-group-2 branch Apr 20, 2019

@niden niden added the Docs needed label May 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.