Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed logic in many methods (part 2). #14013

Merged
merged 5 commits into from Apr 24, 2019

Conversation

Projects
4 participants
@SidRoberts
Copy link
Member

commented Apr 24, 2019

Hello!

  • Type: code quality
  • Link to issue:

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • [-] I wrote some tests for this PR
  • [-] I updated the CHANGELOG

Small description of change:

Thanks

@SidRoberts

This comment has been minimized.

Copy link
Member Author

commented Apr 24, 2019

Another commit is incoming. 😝

@codecov

This comment has been minimized.

Copy link

commented Apr 24, 2019

Codecov Report

Merging #14013 into 4.0.x will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            4.0.x   #14013      +/-   ##
==========================================
+ Coverage   68.29%   68.32%   +0.03%     
==========================================
  Files         469      469              
  Lines       94310    94227      -83     
==========================================
- Hits        64407    64381      -26     
+ Misses      29903    29846      -57
Impacted Files Coverage Δ
ext/phalcon/mvc/application.zep.c 66.75% <0%> (-0.38%) ⬇️
ext/phalcon/db/adapter.zep.c 51.81% <0%> (-0.16%) ⬇️
ext/phalcon/http/response.zep.c 88.41% <0%> (-0.08%) ⬇️
ext/phalcon/http/request.zep.c 80.99% <0%> (-0.05%) ⬇️
ext/phalcon/http/message/request.zep.c 87.53% <0%> (-0.04%) ⬇️
ext/phalcon/http/message/serverrequest.zep.c 88.1% <0%> (-0.03%) ⬇️
ext/phalcon/http/message/response.zep.c 93.38% <0%> (-0.03%) ⬇️
ext/phalcon/mvc/model/query.zep.c 60.45% <0%> (-0.02%) ⬇️
ext/phalcon/mvc/view/engine/volt/compiler.zep.c 66.52% <0%> (-0.02%) ⬇️
ext/phalcon/http/response/headers.zep.c 91.81% <0%> (ø) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ad676b...f0ec1c6. Read the comment docs.

SidRoberts added some commits Apr 24, 2019

Show resolved Hide resolved phalcon/Http/Request.zep Outdated

@SidRoberts SidRoberts force-pushed the SidRoberts:logic-2 branch from 0641ed6 to f0ec1c6 Apr 24, 2019

@SidRoberts

This comment has been minimized.

Copy link
Member Author

commented Apr 24, 2019

I've finished with this now so it can be merged whenever.

@niden

niden approved these changes Apr 24, 2019

@niden niden merged commit ea2d1bd into phalcon:4.0.x Apr 24, 2019

3 checks passed

codecov/patch Coverage not affected when comparing 8ad676b...f0ec1c6
Details
codecov/project 68.32% (+0.03%) compared to 8ad676b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@niden

This comment has been minimized.

Copy link
Member

commented Apr 24, 2019

Thank you @SidRoberts

@niden niden added the Enhancement label Apr 24, 2019

@niden niden added this to In progress in 4.0 Release via automation Apr 24, 2019

SidRoberts added a commit to SidRoberts/cphalcon that referenced this pull request Apr 25, 2019

Fixed logic in many methods (part 2). (phalcon#14013)
* Fixed logic in many methods (part 2).

* Fixed logic. (part 2.1)

* Fixed logic. (part 2.2)

* Removed fix for PHP bug 66606.

* Fixed logic 2.something.

SidRoberts added a commit to SidRoberts/cphalcon that referenced this pull request Apr 25, 2019

Fixed logic in many methods (part 2). (phalcon#14013)
* Fixed logic in many methods (part 2).

* Fixed logic. (part 2.1)

* Fixed logic. (part 2.2)

* Removed fix for PHP bug 66606.

* Fixed logic 2.something.

@niden niden moved this from In progress to Done in 4.0 Release Apr 26, 2019

@SidRoberts SidRoberts deleted the SidRoberts:logic-2 branch Jun 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.