Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more tests #14125

Merged
merged 9 commits into from May 25, 2019

Conversation

@SidRoberts
Copy link
Member

commented May 25, 2019

Hello!

  • Type: tests
  • Link to issue:

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • [-] I have updated the relevant CHANGELOG
  • [-] I have created a PR for the documentation about this change

I also had to fix Db\Dialect\Postgresql::truncateTable() as it previously didn't escape table names.

@SidRoberts SidRoberts force-pushed the SidRoberts:tests-may25 branch 2 times, most recently from 87e233a to 62ccd7d May 25, 2019

@codecov

This comment has been minimized.

Copy link

commented May 25, 2019

Codecov Report

Merging #14125 into 4.0.x will increase coverage by 0.37%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            4.0.x   #14125      +/-   ##
==========================================
+ Coverage   72.26%   72.64%   +0.37%     
==========================================
  Files         464      464              
  Lines       96061    96060       -1     
==========================================
+ Hits        69422    69786     +364     
+ Misses      26639    26274     -365
Impacted Files Coverage Δ
ext/phalcon/db/dialect/postgresql.zep.c 74.65% <0%> (-0.03%) ⬇️
ext/phalcon/db/dialect.zep.c 72.2% <0%> (+0.13%) ⬆️
ext/phalcon/validation.zep.c 78.96% <0%> (+1.66%) ⬆️
ext/phalcon/loader.zep.c 88.03% <0%> (+1.73%) ⬆️
ext/phalcon/db/dialect/sqlite.zep.c 66.6% <0%> (+5.12%) ⬆️
ext/phalcon/registry.zep.c 86.53% <0%> (+8.75%) ⬆️
ext/phalcon/db/dialect/mysql.zep.c 72.44% <0%> (+17.26%) ⬆️
ext/phalcon/3__closure.zep.c 83.33% <0%> (+66.66%) ⬆️
ext/phalcon/4__closure.zep.c 83.33% <0%> (+66.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f74ba2b...ae267a3. Read the comment docs.

@SidRoberts SidRoberts force-pushed the SidRoberts:tests-may25 branch 3 times, most recently from 7647584 to f0b43b1 May 25, 2019

@SidRoberts SidRoberts force-pushed the SidRoberts:tests-may25 branch 8 times, most recently from 93e8c98 to 703fbaa May 25, 2019

@SidRoberts SidRoberts force-pushed the SidRoberts:tests-may25 branch from 703fbaa to ae267a3 May 25, 2019

@niden

niden approved these changes May 25, 2019

@niden niden merged commit c6c55bd into phalcon:4.0.x May 25, 2019

4 checks passed

codecov/patch Coverage not affected when comparing f74ba2b...ae267a3
Details
codecov/project 72.64% (+0.37%) compared to f74ba2b
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@niden

This comment has been minimized.

Copy link
Member

commented May 25, 2019

Thank you @SidRoberts

@niden niden added the Testing label May 25, 2019

@niden niden added this to In progress in 4.0 Release via automation May 25, 2019

@niden niden moved this from In progress to Done in 4.0 Release May 25, 2019

@SidRoberts SidRoberts deleted the SidRoberts:tests-may25 branch May 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.