Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSR-7 - Tests and refactoring #14154

Merged
merged 16 commits into from Jun 3, 2019

Conversation

@niden
Copy link
Member

commented Jun 3, 2019

Hello!

  • Type: new feature/code quality
  • Link to issue: #11789

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Small description of change:

Thanks

niden added some commits Jun 1, 2019

Yuuge refactor
Introduced new `load` method for ServerRequestFactory to load from superglobals
Refactored Collection to allow conditional key case sensitivity
Introduced ReadCollection
Refactored Registry to align with Collection
Moved Collection to its own namespace
Loads of tests with more code coverage

@niden niden added this to In progress in 4.0 Release via automation Jun 3, 2019

niden added some commits Jun 3, 2019

@niden niden merged commit 8b0dec0 into phalcon:4.0.x Jun 3, 2019

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

4.0 Release automation moved this from In progress to Done Jun 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
1 participant
You can’t perform that action at this time.