Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes and improvements #14208

Merged
merged 4 commits into from Jun 25, 2019
Merged

Bug fixes and improvements #14208

merged 4 commits into from Jun 25, 2019

Conversation

ekmst
Copy link
Contributor

@ekmst ekmst commented Jun 25, 2019

Hello!

  • Type: bug fix | code quality
  • Link to issue:

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Small description of change:
bug fixes and improvements on validators

Thanks

@codecov
Copy link

codecov bot commented Jun 25, 2019

Codecov Report

Merging #14208 into 4.0.x will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            4.0.x   #14208      +/-   ##
==========================================
- Coverage   66.31%    66.3%   -0.01%     
==========================================
  Files         475      475              
  Lines      111700   111746      +46     
==========================================
+ Hits        74078    74098      +20     
- Misses      37622    37648      +26
Impacted Files Coverage Δ
...xt/phalcon/validation/validator/stringlength.zep.c 52.65% <0%> (+0.41%) ⬆️
ext/phalcon/validation/validator/file.zep.c 28.53% <0%> (+0.99%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e777bc8...b88ef39. Read the comment docs.

@niden niden added 4.0 enhancement Enhancement to the framework labels Jun 25, 2019
@niden niden added this to In progress in 4.0.0 Release via automation Jun 25, 2019
@niden niden merged commit cb03d23 into phalcon:4.0.x Jun 25, 2019
4.0.0 Release automation moved this from In progress to Done Jun 25, 2019
@niden
Copy link
Sponsor Member

niden commented Jun 25, 2019

Thank you @ekmst

@ekmst ekmst deleted the validators branch June 26, 2019 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to the framework
Projects
No open projects
4.0.0 Release
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants