Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HAVE_SPL #14215

Closed
wants to merge 1 commit into from

Conversation

@petk
Copy link

commented Jun 26, 2019

Hello!

  • Type: bug fix
  • Link to issue: /

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Small description of change:

The HAVE_SPL symbol is defined in PHP to indicate the presence of the spl extension. Since PHP 5.3 the SPL extension is always availabe and since PHP-7.4 the HAVE_SPL symbol has also been removed.

Thanks

The HAVE_SPL symbol is defined in PHP to indicate the presence of the
spl extension. Since PHP 5.3 the SPL extension is always availabe and
since PHP-7.4 the HAVE_SPL symbol has also been removed.
@niden

This comment has been minimized.

Copy link
Member

commented Jun 26, 2019

@petk Thank you for this but I will have to decline it. Here is why

These files are automatically generated when we run zephir build As such, these changes will be overwritten the next time we release a version and thus generate the build

However you can send the same PR in the Zephir repository and that will propagate here also.

Have a look at this:

https://github.com/phalcon/zephir/search?q=HAVE_SPL&unscoped_q=HAVE_SPL

These are the files/templates that the HAVE_SPL is defined.

Thanks for this !!

@petk

This comment has been minimized.

Copy link
Author

commented Jun 27, 2019

Got it.. Ok. more coming up tomorrow then.

@sergeyklay sergeyklay self-assigned this Jun 27, 2019
sergeyklay added a commit to phalcon/zephir that referenced this pull request Jun 27, 2019
@sergeyklay

This comment has been minimized.

Copy link
Member

commented Jun 27, 2019

Done:

$ ag --cc HAVE_SPL ext/ | wc -l
0
$ ag --cc HAVE_SPL build/ | wc -l
0

Thank you for the report, and for helping us make Phalcon better!

@sergeyklay sergeyklay closed this Jun 27, 2019
@petk petk deleted the petk:patch-have-spl branch Jun 27, 2019
sergeyklay added a commit to phalcon/zephir that referenced this pull request Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.