Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Form::getValue() calling getAttributes() when an element is named "attributes" #14226

Merged
merged 3 commits into from Jul 1, 2019

Conversation

@zsilbi
Copy link
Contributor

commented Jul 1, 2019

Hello!

  • Type: bug fix
  • Link to issue: #13646

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I have updated the relevant CHANGELOG

Small description of change:

The getAttributes() method was added to Phalcon\Form\Form, but it wasn't added to the internal methods array.
Phalcon\Form\Form::getValue('attributes') returns the attributes from Phalcon\Form\Form::getAttributes() instead of the value of the Element, named attributes.

Thanks,
zsilbi

Németh Balázs added some commits Jul 1, 2019

@codecov

This comment has been minimized.

Copy link

commented Jul 1, 2019

Codecov Report

Merging #14226 into 4.0.x will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            4.0.x   #14226      +/-   ##
==========================================
+ Coverage   66.31%   66.31%   +<.01%     
==========================================
  Files         475      475              
  Lines      111596   111597       +1     
==========================================
+ Hits        74004    74005       +1     
  Misses      37592    37592
Impacted Files Coverage Δ
ext/phalcon/forms/form.zep.c 73% <0%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f4fe86...7f857c5. Read the comment docs.

@niden

niden approved these changes Jul 1, 2019

@niden niden merged commit da40f2f into phalcon:4.0.x Jul 1, 2019

4 checks passed

codecov/patch Coverage not affected when comparing 9f4fe86...7f857c5
Details
codecov/project 66.31% (+<.01%) compared to 9f4fe86
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@niden

This comment has been minimized.

Copy link
Member

commented Jul 1, 2019

Thank you @zsilbi

@niden niden added this to In progress in 4.0 Release via automation Jul 1, 2019

@niden niden moved this from In progress to Done in 4.0 Release Jul 1, 2019

@zsilbi zsilbi deleted the zsilbi:form-attributes-element-value-fix branch Jul 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.