Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo rename #14234

Merged
merged 20 commits into from Jul 5, 2019

Conversation

Projects
2 participants
@niden
Copy link
Member

commented Jul 5, 2019

Hello!

  • Type: enhancement
  • Link to issue:

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Moved some classes back to the root namespace

Thanks

niden added some commits Jul 5, 2019

@niden niden added this to In progress in 4.0 Release via automation Jul 5, 2019

niden added some commits Jul 5, 2019

Show resolved Hide resolved CHANGELOG-4.0.md Outdated

niden added some commits Jul 5, 2019

@codecov

This comment has been minimized.

Copy link

commented Jul 5, 2019

Codecov Report

Merging #14234 into 4.0.x will decrease coverage by 0.92%.
The diff coverage is 60.49%.

Impacted file tree graph

@@            Coverage Diff             @@
##            4.0.x   #14234      +/-   ##
==========================================
- Coverage   66.82%   65.89%   -0.93%     
==========================================
  Files         445      489      +44     
  Lines      102162   112599   +10437     
==========================================
+ Hits        68267    74202    +5935     
- Misses      33895    38397    +4502
Impacted Files Coverage Δ
ext/phalcon/firewall/adapter/abstractadapter.zep.c 86.34% <ø> (ø)
ext/phalcon/acl/roleinterface.zep.c 100% <ø> (ø) ⬆️
ext/phalcon/events/manager.zep.c 81.33% <ø> (ø) ⬆️
ext/phalcon/assets/asset/css.zep.c 90.74% <ø> (ø) ⬆️
ext/phalcon/http/message/request.zep.c 100% <ø> (ø) ⬆️
ext/phalcon/annotations/readerinterface.zep.c 100% <ø> (ø) ⬆️
ext/phalcon/forms/element/select.zep.c 73.03% <ø> (ø) ⬆️
ext/phalcon/db/result/pdo.zep.c 84.72% <ø> (ø) ⬆️
...phalcon/annotations/adapter/adapterinterface.zep.c 100% <ø> (ø) ⬆️
ext/phalcon/html/breadcrumbs.zep.c 77.72% <ø> (ø) ⬆️
... and 341 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3aad34...f5842c8. Read the comment docs.

@niden niden merged commit 73dad14 into phalcon:4.0.x Jul 5, 2019

2 of 4 checks passed

codecov/patch 60.49% of diff hit (target 66.82%)
Details
codecov/project 65.89% (-0.93%) compared to d3aad34
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

4.0 Release automation moved this from In progress to Done Jul 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.