Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog.md v3 #14251

Merged
merged 2 commits into from Jul 21, 2019

Conversation

@Arhell
Copy link
Member

commented Jul 20, 2019

Hello!

  • Change changelog.md

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Small description of change:

Thanks

@ruudboon
Copy link
Member

left a comment

We're not really updating v3 but makes sense to me to merge this. Looks good

@sergeyklay sergeyklay changed the base branch from master to 4.0.x Jul 21, 2019

@sergeyklay sergeyklay changed the base branch from 4.0.x to master Jul 21, 2019

@sergeyklay

This comment has been minimized.

Copy link
Member

commented Jul 21, 2019

@Arhell Could you send this PR to the 4.0.x branch?

@Arhell Arhell changed the base branch from master to 4.0.x Jul 21, 2019

@Arhell

This comment has been minimized.

Copy link
Member Author

commented Jul 21, 2019

@Arhell Arhell force-pushed the Arhell:upd-changelog-3v branch from d2abc23 to 109ed5c Jul 21, 2019

@codecov

This comment has been minimized.

Copy link

commented Jul 21, 2019

Codecov Report

Merging #14251 into 4.0.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            4.0.x   #14251   +/-   ##
=======================================
  Coverage   65.89%   65.89%           
=======================================
  Files         489      489           
  Lines      112605   112605           
=======================================
  Hits        74200    74200           
  Misses      38405    38405

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68fed33...d350a14. Read the comment docs.

@Arhell Arhell force-pushed the Arhell:upd-changelog-3v branch 2 times, most recently from 30f8df9 to 11e7f64 Jul 21, 2019

@Arhell Arhell force-pushed the Arhell:upd-changelog-3v branch from 11e7f64 to dd847c7 Jul 21, 2019

@sergeyklay sergeyklay merged commit 2be495d into phalcon:4.0.x Jul 21, 2019

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@sergeyklay

This comment has been minimized.

Copy link
Member

commented Jul 21, 2019

Thank you

@Arhell Arhell deleted the Arhell:upd-changelog-3v branch Jul 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.