Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T13697 remove mongo from 4.0 #14361

Merged
merged 10 commits into from Sep 7, 2019

Conversation

@niden
Copy link
Member

niden commented Sep 7, 2019

Hello!

  • Type: temporary
  • Link to issue: #13697

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Removed the mongo collection classes from v4 since they are outdated. There is already work for the new version of the mongo driver in #13697 for 4.1

Thanks

niden added 4 commits Sep 7, 2019
@niden niden changed the base branch from master to 4.0.x Sep 7, 2019
@niden niden added this to In progress in 4.0 Release via automation Sep 7, 2019
niden added 4 commits Sep 7, 2019
This reverts commit bb2affa.
niden added 2 commits Sep 7, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Sep 7, 2019

Codecov Report

Merging #14361 into 4.0.x will increase coverage by 1.53%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            4.0.x   #14361      +/-   ##
==========================================
+ Coverage   66.29%   67.82%   +1.53%     
==========================================
  Files         487      477      -10     
  Lines      115843   113127    -2716     
==========================================
- Hits        76801    76732      -69     
+ Misses      39042    36395    -2647
@niden niden merged commit bd56301 into phalcon:4.0.x Sep 7, 2019
4 checks passed
4 checks passed
codecov/patch Coverage not affected when comparing 16af7f2...606346e
Details
codecov/project 67.82% (+1.53%) compared to 16af7f2
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
4.0 Release automation moved this from In progress to Done Sep 7, 2019
@niden niden deleted the niden:T13697-remove-mongo-from-4.0 branch Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4.0 Release
  
Done
2 participants
You can’t perform that action at this time.