Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0.x] - Renamed the arrayToObject to toObject #14389

Merged
merged 4 commits into from Sep 17, 2019

Conversation

@niden
Copy link
Member

niden commented Sep 17, 2019

Hello!

  • Type: code quality
  • Link to issue:

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Renamed the arrayToObject to toObject from the Arr helper

Thanks

@niden niden added this to In progress in 4.0 Release via automation Sep 17, 2019
niden added 3 commits Sep 17, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Sep 17, 2019

Codecov Report

Merging #14389 into 4.0.x will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            4.0.x   #14389      +/-   ##
==========================================
+ Coverage   67.63%   67.64%   +<.01%     
==========================================
  Files         478      478              
  Lines      110989   110959      -30     
==========================================
- Hits        75069    75053      -16     
+ Misses      35920    35906      -14
@niden niden merged commit 8b5113b into phalcon:4.0.x Sep 17, 2019
4 checks passed
4 checks passed
codecov/patch Coverage not affected when comparing 25a2aab...42e3f44
Details
codecov/project 67.64% (+<.01%) compared to 25a2aab
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
4.0 Release automation moved this from In progress to Done Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4.0 Release
  
Done
1 participant
You can’t perform that action at this time.