Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constructors should never declare return type [skip appveyor] #14401

Merged
merged 1 commit into from Sep 22, 2019

Conversation

@sergeyklay
Copy link
Member

sergeyklay commented Sep 22, 2019

Hello!

  • Type: bug fix
  • Link to issue: -

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Small description of change: Constructors should never declare return type.
Thanks.

/cc @niden

@sergeyklay sergeyklay self-assigned this Sep 22, 2019
@sergeyklay sergeyklay added the 4.0 label Sep 22, 2019
@ruudboon

This comment has been minimized.

Copy link
Member

ruudboon commented Sep 22, 2019

Is this something Zephir specific? Looks like the default return type is void

https://www.php.net/manual/en/language.oop5.decon.php#object.construct

@sergeyklay

This comment has been minimized.

Copy link
Member Author

sergeyklay commented Sep 22, 2019

Zephir != PHP. Did you see something related in the Zephir docs? PHP driven development in Zephir leads to unexpected results: https://travis-ci.org/phalcon/cphalcon/jobs/588067789

@ruudboon

This comment has been minimized.

Copy link
Member

ruudboon commented Sep 22, 2019

Zephir != PHP. Did you see something related in the Zephir docs? PHP driven development in Zephir leads to unexpected results: https://travis-ci.org/phalcon/cphalcon/jobs/588067789

Missed it btw in the docs of Zephir.

@sergeyklay

This comment has been minimized.

Copy link
Member Author

sergeyklay commented Sep 22, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Sep 22, 2019

Codecov Report

Merging #14401 into 4.0.x will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            4.0.x   #14401   +/-   ##
=======================================
  Coverage   67.63%   67.63%           
=======================================
  Files         478      478           
  Lines      110961   110961           
=======================================
  Hits        75053    75053           
  Misses      35908    35908
@sergeyklay sergeyklay merged commit f287e8e into 4.0.x Sep 22, 2019
4 checks passed
4 checks passed
codecov/patch Coverage not affected when comparing d0721ce...e3f06d2
Details
codecov/project 67.63% remains the same compared to d0721ce
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@sergeyklay sergeyklay deleted the fix/remove-contructors-return-declaration branch Sep 22, 2019
@niden niden added the Enhancement label Sep 22, 2019
@niden niden added this to In progress in 4.0 Release via automation Sep 22, 2019
@niden niden moved this from In progress to Done in 4.0 Release Sep 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4.0 Release
  
Done
3 participants
You can’t perform that action at this time.