Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test corrections - EV interface #14404

Merged
merged 4 commits into from Sep 22, 2019

Conversation

@niden
Copy link
Member

niden commented Sep 22, 2019

Hello!

  • Type: bug fix | testing
  • Link to issue:

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Corrected tests; Corrected Logger/Adapter/add interface; Added null in getEventsManager

Thanks

niden added 4 commits Sep 22, 2019
@niden niden added this to In progress in 4.0 Release via automation Sep 22, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Sep 22, 2019

Codecov Report

Merging #14404 into 4.0.x will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            4.0.x   #14404      +/-   ##
==========================================
+ Coverage   67.63%   67.63%   +<.01%     
==========================================
  Files         478      478              
  Lines      110961   110962       +1     
==========================================
+ Hits        75053    75054       +1     
  Misses      35908    35908
@niden niden merged commit 902910a into phalcon:4.0.x Sep 22, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
4.0 Release automation moved this from In progress to Done Sep 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4.0 Release
  
Done
2 participants
You can’t perform that action at this time.