Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed class errors #14414

Merged
merged 4 commits into from Sep 24, 2019

Conversation

@ruudboon
Copy link
Member

ruudboon commented Sep 24, 2019

Hello!

  • Type: code quality

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Detected more missing/wrong use statements or outdated return types.

ruudboon added 2 commits Sep 24, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Sep 24, 2019

Codecov Report

Merging #14414 into 4.0.x will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            4.0.x   #14414   +/-   ##
=======================================
  Coverage   67.64%   67.64%           
=======================================
  Files         478      478           
  Lines      110970   110970           
=======================================
  Hits        75061    75061           
  Misses      35909    35909
@niden
niden approved these changes Sep 24, 2019
@ruudboon ruudboon merged commit b7108af into phalcon:4.0.x Sep 24, 2019
4 checks passed
4 checks passed
codecov/patch Coverage not affected when comparing ee22f5d...73ed388
Details
codecov/project 67.64% remains the same compared to ee22f5d
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ruudboon ruudboon deleted the ruudboon:class-errors branch Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.