Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firewall improvement #14450

Merged
merged 14 commits into from Oct 5, 2019

Conversation

@ruudboon
Copy link
Member

ruudboon commented Oct 5, 2019

Hello!

  • Type: bug fix
  • Link to issue:#14449

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Small description of change:

Thanks

@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 5, 2019

Codecov Report

Merging #14450 into 4.0.x will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            4.0.x   #14450      +/-   ##
==========================================
- Coverage   67.71%    67.7%   -0.01%     
==========================================
  Files         482      482              
  Lines      111207   111222      +15     
==========================================
+ Hits        75304    75308       +4     
- Misses      35903    35914      +11
@niden niden added this to In progress in 4.0 Release via automation Oct 5, 2019
ruudboon and others added 13 commits Oct 5, 2019
Added check
@niden niden force-pushed the ruudboon:firewall-improvement branch from a43d3af to 9a7ed71 Oct 5, 2019
@niden
niden approved these changes Oct 5, 2019
@niden niden merged commit cfe2c02 into phalcon:4.0.x Oct 5, 2019
4.0 Release automation moved this from In progress to Done Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4.0 Release
  
Done
3 participants
You can’t perform that action at this time.