Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface corrections #14477

Merged
merged 4 commits into from Oct 17, 2019

Conversation

@niden
Copy link
Member

niden commented Oct 16, 2019

Hello!

  • Type: bug fix
  • Link to issue:

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Corrected interfaces for Events Manager

Thanks

@niden niden changed the base branch from master to 4.0.x Oct 16, 2019
@niden niden added this to In progress in 4.0 Release via automation Oct 16, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 17, 2019

Codecov Report

Merging #14477 into 4.0.x will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            4.0.x   #14477      +/-   ##
==========================================
+ Coverage   67.67%    67.7%   +0.02%     
==========================================
  Files         482      482              
  Lines      111321   111350      +29     
==========================================
+ Hits        75335    75386      +51     
+ Misses      35986    35964      -22
niden added 2 commits Oct 17, 2019
@niden niden merged commit ae7a7e5 into phalcon:4.0.x Oct 17, 2019
4 checks passed
4 checks passed
codecov/patch Coverage not affected when comparing f69e251...d68b949
Details
codecov/project 67.7% (+0.02%) compared to f69e251
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
4.0 Release automation moved this from In progress to Done Oct 17, 2019
@niden niden deleted the niden:interface-corrections branch Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4.0 Release
  
Done
2 participants
You can’t perform that action at this time.