Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting again interfaces and added tests #14494

Merged
merged 4 commits into from Oct 28, 2019
Merged

Conversation

@niden
Copy link
Member

niden commented Oct 28, 2019

Hello!

  • Type: bug fix
  • Link to issue:

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Fixed interfaces for factory, added tests

Thanks

niden added 2 commits Oct 28, 2019
@niden niden changed the title [4.0.x] - Correcting again interfaces and added tests [WIP] - Correcting again interfaces and added tests Oct 28, 2019
@ruudboon

This comment has been minimized.

Copy link
Member

ruudboon commented Oct 28, 2019

@niden Running phpcbf should fix the CI build error.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 28, 2019

Codecov Report

Merging #14494 into 4.0.x will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            4.0.x   #14494      +/-   ##
==========================================
- Coverage    67.7%    67.7%   -0.01%     
==========================================
  Files         482      482              
  Lines      111384   111388       +4     
==========================================
+ Hits        75416    75418       +2     
- Misses      35968    35970       +2
@niden niden changed the title [WIP] - Correcting again interfaces and added tests Correcting again interfaces and added tests Oct 28, 2019
@niden niden merged commit 5d0c288 into phalcon:4.0.x Oct 28, 2019
4 checks passed
4 checks passed
codecov/patch Coverage not affected when comparing a4ca3e0...277e58f
Details
codecov/project 67.7% (-0.01%) compared to a4ca3e0
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@niden niden added this to In progress in 4.0 Release via automation Oct 28, 2019
@niden niden moved this from In progress to Done in 4.0 Release Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4.0 Release
  
Done
3 participants
You can’t perform that action at this time.