Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container fix #14502

Merged
merged 4 commits into from Nov 1, 2019
Merged

Container fix #14502

merged 4 commits into from Nov 1, 2019

Conversation

@niden
Copy link
Member

niden commented Nov 1, 2019

Hello!

  • Type: bug fix
  • Link to issue:

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Fixed Phalcon\Container:get to use getShared transparently

Thanks

niden added 4 commits Oct 28, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 1, 2019

Codecov Report

Merging #14502 into 4.0.x will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            4.0.x   #14502   +/-   ##
=======================================
  Coverage    67.7%    67.7%           
=======================================
  Files         482      482           
  Lines      111388   111388           
=======================================
  Hits        75418    75418           
  Misses      35970    35970
@niden niden added this to In progress in 4.0 Release via automation Nov 1, 2019
@niden niden merged commit 8777c10 into phalcon:4.0.x Nov 1, 2019
4 checks passed
4 checks passed
codecov/patch Coverage not affected when comparing 3cfaabc...41e3f75
Details
codecov/project 67.7% remains the same compared to 3cfaabc
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
4.0 Release automation moved this from In progress to Done Nov 1, 2019
@niden niden deleted the niden:container-fix branch Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4.0 Release
  
Done
3 participants
You can’t perform that action at this time.