Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Model\Manager::getRelations() and getRelationsBetween() #14509

Merged
merged 2 commits into from Nov 5, 2019

Conversation

@zsilbi
Copy link
Contributor

zsilbi commented Nov 3, 2019

Hello!

  • Type: bug fix

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Small description of change:

Fixed Phalcon\Mvc\Model\Manager::getRelations() and getRelationsBetween() to return many-to-many relations correctly.

Thanks,
zsilbi

@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 4, 2019

Codecov Report

Merging #14509 into 4.0.x will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            4.0.x   #14509      +/-   ##
==========================================
+ Coverage   67.69%   67.69%   +<.01%     
==========================================
  Files         482      482              
  Lines      111758   111763       +5     
==========================================
+ Hits        75659    75663       +4     
- Misses      36099    36100       +1
@niden

This comment has been minimized.

Copy link
Member

niden commented Nov 4, 2019

@zsilbi When you get a chance can you rebase this please?

@zsilbi zsilbi force-pushed the zsilbi:model-bugfixes branch from a676e0b to 30a7bd3 Nov 5, 2019
@zsilbi zsilbi force-pushed the zsilbi:model-bugfixes branch from 30a7bd3 to deadb3f Nov 5, 2019
@zsilbi zsilbi requested a review from niden Nov 5, 2019
@niden
niden approved these changes Nov 5, 2019
@niden niden added this to In progress in 4.0 Release via automation Nov 5, 2019
@niden niden merged commit 330e285 into phalcon:4.0.x Nov 5, 2019
1 of 4 checks passed
1 of 4 checks passed
codecov/patch CI failed.
Details
codecov/project CI failed.
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
4.0 Release automation moved this from In progress to Done Nov 5, 2019
@niden

This comment has been minimized.

Copy link
Member

niden commented Nov 5, 2019

Thank you @zsilbi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4.0 Release
  
Done
2 participants
You can’t perform that action at this time.