Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model has-one-through relations #14511

Merged
merged 9 commits into from Nov 4, 2019
Merged

Conversation

@zsilbi
Copy link
Contributor

zsilbi commented Nov 4, 2019

Hello!

  • Type: new feature

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Small description of change:

This is very similar to hasManyToMany, but it can only use one intermediate row.
The related record is either ModelInterface, or null.

This is kind of an antipattern, but it can be useful when you have to work with a poorly designed database structure that can't be altered.

Thanks,
zsilbi

@niden niden added this to In progress in 4.0 Release via automation Nov 4, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 4, 2019

Codecov Report

Merging #14511 into 4.0.x will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            4.0.x   #14511      +/-   ##
==========================================
- Coverage   67.74%    67.7%   -0.05%     
==========================================
  Files         482      482              
  Lines      111424   111754     +330     
==========================================
+ Hits        75483    75659     +176     
- Misses      35941    36095     +154
@niden niden merged commit ecdbb93 into phalcon:4.0.x Nov 4, 2019
4 checks passed
4 checks passed
codecov/patch Coverage not affected when comparing 169e9ab...0a98275
Details
codecov/project 67.7% (-0.05%) compared to 169e9ab
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
4.0 Release automation moved this from In progress to Done Nov 4, 2019
@niden

This comment has been minimized.

Copy link
Member

niden commented Nov 4, 2019

Thank you @zsilbi

@niden niden removed the Docs needed label Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4.0 Release
  
Done
4 participants
You can’t perform that action at this time.