Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Mysql column definition #14645

Merged
merged 2 commits into from Dec 23, 2019
Merged

Fixed Mysql column definition #14645

merged 2 commits into from Dec 23, 2019

Conversation

@pfz
Copy link
Contributor

pfz commented Dec 23, 2019

remove unwanted parenthesis closure for DOUBLE, FLOAT... definitions

remove unwanted parenthesis closure for DOUBLE, FLOAT... definitions
@ruudboon

This comment has been minimized.

Copy link
Member

ruudboon commented Dec 23, 2019

@pfz Would it possible to add a test for this as well?

@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 23, 2019

Codecov Report

Merging #14645 into 4.0.x will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            4.0.x   #14645      +/-   ##
==========================================
+ Coverage   67.45%   67.46%   +<.01%     
==========================================
  Files         483      483              
  Lines      111370   111369       -1     
==========================================
+ Hits        75128    75138      +10     
+ Misses      36242    36231      -11
@niden niden added 4.0 labels Dec 23, 2019
@ruudboon ruudboon merged commit d385e3c into phalcon:4.0.x Dec 23, 2019
5 checks passed
5 checks passed
phpcs
Details
codecov/patch Coverage not affected when comparing 65bfee4...36604dd
Details
codecov/project 67.46% (+<.01%) compared to 65bfee4
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ruudboon

This comment has been minimized.

Copy link
Member

ruudboon commented Dec 23, 2019

@pfz Thank you!

@pfz pfz deleted the pfz:fix-mysql-column-def branch Dec 23, 2019
@niden niden added bug status: medium and removed Bug - Medium labels Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.