Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect `Phalcon\Factory\ValidatorInterface` #14749

Merged
merged 3 commits into from Jan 22, 2020
Merged

Conversation

@ruudboon
Copy link
Member

ruudboon commented Jan 21, 2020

Hello!

  • Type: bug fix
  • Link to issue:

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Small description of change:
Fixed issue with non existing interface used

@niden niden added this to Working on it in Phalcon Roadmap Jan 21, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 22, 2020

Codecov Report

Merging #14749 into 4.0.x will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            4.0.x   #14749      +/-   ##
==========================================
+ Coverage   67.97%   67.98%   +<.01%     
==========================================
  Files         483      483              
  Lines      111435   111435              
==========================================
+ Hits        75752    75758       +6     
+ Misses      35683    35677       -6
@niden niden merged commit e9b31fc into phalcon:4.0.x Jan 22, 2020
12 checks passed
12 checks passed
Build Phalcon Pecl Package Build Phalcon Pecl Package
Details
phpcs
Details
PHP 7.2 Test on ubuntu-latest PHP 7.2 Test on ubuntu-latest
Details
PHP 7.3 Test on ubuntu-latest PHP 7.3 Test on ubuntu-latest
Details
PHP 7.4 Test on ubuntu-latest PHP 7.4 Test on ubuntu-latest
Details
PHP 7.2 Test on macOS-latest PHP 7.2 Test on macOS-latest
Details
PHP 7.3 Test on macOS-latest PHP 7.3 Test on macOS-latest
Details
PHP 7.4 Test on macOS-latest PHP 7.4 Test on macOS-latest
Details
codecov/patch Coverage not affected when comparing 224a25b...e9b31fc
Details
codecov/project 67.98% (+<.01%) compared to 224a25b
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Phalcon Roadmap automation moved this from Working on it to Implemented Jan 22, 2020
@niden niden moved this from Implemented to Released in Phalcon Roadmap Jan 26, 2020
@ruudboon ruudboon deleted the ruudboon:stubs-errors branch Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Phalcon Roadmap
  
Released
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.