Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cache] - Cache Serializer options #14828

Merged
merged 2 commits into from Feb 9, 2020
Merged

Conversation

@niden
Copy link
Member

niden commented Feb 9, 2020

Hello!

  • Type: bug fix
  • Link to issue:

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Fixed Phalcon\Storage\Adapter\* to no longer accept the serializer option as it was clashing with the factory

Thanks

niden added 2 commits Feb 9, 2020
…lides with the factory
@niden niden self-assigned this Feb 9, 2020
@niden niden added this to Working on it in Phalcon Roadmap Feb 9, 2020
@niden niden changed the title [cache] - Removed option to set the serializer from the options - col… [cache] - Cache Serializer options Feb 9, 2020
@niden niden merged commit 470383b into phalcon:4.0.x Feb 9, 2020
17 checks passed
17 checks passed
Build & Run
Details
Build Phalcon Pecl Package
Details
phpcs
Details
PHP 7.2 Test on ubuntu-latest
Details
PHP 7.3 Test on ubuntu-latest
Details
PHP 7.4 Test on ubuntu-latest
Details
PHP 7.2 Test on macos-latest PHP 7.2 Test on macos-latest
Details
PHP 7.3 Test on macos-latest PHP 7.3 Test on macos-latest
Details
PHP 7.4 Test on macos-latest PHP 7.4 Test on macos-latest
Details
PHP 7.2 (ts) test on windows-2016 PHP 7.2 (ts) test on windows-2016
Details
PHP 7.2 (nts) test on windows-2016 PHP 7.2 (nts) test on windows-2016
Details
PHP 7.3 (ts) test on windows-2016 PHP 7.3 (ts) test on windows-2016
Details
PHP 7.3 (nts) test on windows-2016 PHP 7.3 (nts) test on windows-2016
Details
PHP 7.4 (ts) test on windows-2016 PHP 7.4 (ts) test on windows-2016
Details
PHP 7.4 (nts) test on windows-2016 PHP 7.4 (nts) test on windows-2016
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Phalcon Roadmap automation moved this from Working on it to Implemented Feb 9, 2020
@niden niden moved this from Implemented to Released in Phalcon Roadmap Feb 15, 2020
@niden niden deleted the niden:cache-serializer-options branch Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Phalcon Roadmap
  
Released
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.