Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#13655 - Assets/Collection - Tests finished - Just 2 errors in Phalcon #14848

Merged
merged 4 commits into from Feb 15, 2020

Conversation

@jenovateurs
Copy link
Member

jenovateurs commented Feb 15, 2020

Hi team!
I have a new delivery of test.
Assets/Collection is done.
But I have 3 problems :

  • GitHub display a message : " Can’t automatically merge. Don’t worry, you can still create the pull request. " - I don't know how to solved it.
  • The test Assets/Collection/CurrentCest trigger an error because the variable "position" is not initialize in Phalcon (Error : phalcon/Assets/Collection.zep on line 261)
  • I have the same problem with Asset/Collection/ValidCest, I can't valid my CSS file because "position" is not initialize.

Thanks for your help ;-)

  • Type: code quality
  • Link to issue: #13655

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Thanks

@Jeckerson

This comment has been minimized.

Copy link
Member

Jeckerson commented Feb 15, 2020

" Can’t automatically merge. Don’t worry, you can still create the pull request. " - I don't know how to solved it.

You need to rebase your branch with latest commits from 4.0.x

@Jeckerson

This comment has been minimized.

Copy link
Member

Jeckerson commented Feb 15, 2020

The test Assets/Collection/CurrentCest trigger an error because the variable "position" is not initialize in Phalcon (Error : phalcon/Assets/Collection.zep on line 261)

You can try to set default value:
protected position = 0 { get };

https://github.com/phalcon/cphalcon/blob/master/phalcon/Assets/Collection.zep#L74

jenovateurs added 2 commits Feb 15, 2020
@jenovateurs

This comment has been minimized.

Copy link
Member Author

jenovateurs commented Feb 15, 2020

@Jeckerson Thanks for your help ;-)

phalcon/Assets/Collection.zep Show resolved Hide resolved
@ruudboon ruudboon merged commit 8d90816 into phalcon:4.0.x Feb 15, 2020
17 checks passed
17 checks passed
Build & Run
Details
Build Phalcon Pecl Package
Details
phpcs
Details
PHP 7.2 Test on ubuntu-latest
Details
PHP 7.3 Test on ubuntu-latest
Details
PHP 7.4 Test on ubuntu-latest
Details
PHP 7.2 Test on macos-latest
Details
PHP 7.3 Test on macos-latest
Details
PHP 7.4 Test on macos-latest
Details
PHP 7.2 (ts) test on windows-2016
Details
PHP 7.2 (nts) test on windows-2016
Details
PHP 7.3 (ts) test on windows-2016
Details
PHP 7.3 (nts) test on windows-2016
Details
PHP 7.4 (ts) test on windows-2016
Details
PHP 7.4 (nts) test on windows-2016
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Jeckerson Jeckerson added the testing label Feb 15, 2020
@Jeckerson Jeckerson added this to Implemented in Phalcon Roadmap Feb 15, 2020
@niden niden moved this from Implemented to Released in Phalcon Roadmap Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Phalcon Roadmap
  
Released
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.