New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4: Rewrite contributions.md #2089

Closed
niden opened this Issue Jan 12, 2019 · 6 comments

Comments

3 participants
@niden
Copy link
Member

niden commented Jan 12, 2019

@niden niden self-assigned this Jan 12, 2019

@niden niden added this to ToDo in 4.0 Documentation Jan 12, 2019

@niden niden changed the title Rewrite contributions.md v4: Rewrite contributions.md Jan 12, 2019

@niden niden moved this from ToDo to In Progress in 4.0 Documentation Jan 16, 2019

@niden niden moved this from In Progress to Verify in 4.0 Documentation Jan 16, 2019

@ruudboon

This comment has been minimized.

Copy link

ruudboon commented Jan 16, 2019

Can we add a sections to the contribution how to contribute to the documentation and one for translating?

@niden

This comment has been minimized.

Copy link
Member

niden commented Jan 17, 2019

cc @CameronHall @ruudboon

Comments and review please :)

@CameronHall

This comment has been minimized.

Copy link
Member

CameronHall commented Jan 17, 2019

Should we remove the PR checklist and add that/or a working example to the pull-requests one instead and just leave a reference to it on that page? Doesn't seem very DRY 😉

@niden

This comment has been minimized.

Copy link
Member

niden commented Jan 17, 2019

I don't mind not being DRY in the documentation. I will add a link to the npr file

@niden

This comment has been minimized.

Copy link
Member

niden commented Jan 17, 2019

Implemented

@niden niden closed this Jan 17, 2019

@niden niden moved this from Verify to Done in 4.0 Documentation Jan 17, 2019

@ruudboon

This comment has been minimized.

Copy link

ruudboon commented Jan 17, 2019

If your language is not listed, please send us a message so that we can add it.

Can we link to where to contact the team, or change it to open an issue at Github?

The latest point of the bullet check list has a double slash in the link. It looks like it's working but I think this could cause some issues.

More information here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment